Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug with signing up a User instance #187

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Fixed a bug with signing up a User instance #187

merged 1 commit into from
Jul 5, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jul 5, 2021

Creating a ParseUser instance, populating its properties, and using .signup resulted in the added properties for the ParseUser not being persisted to the Keychain on the client. All the data was saving to the server correctly.

Close #186

@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #187 (80dfa9d) into main (7af659b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   82.45%   82.45%           
=======================================
  Files          71       71           
  Lines        6749     6755    +6     
=======================================
+ Hits         5565     5570    +5     
- Misses       1184     1185    +1     
Impacted Files Coverage Δ
Sources/ParseSwift/API/Responses.swift 90.47% <100.00%> (+1.90%) ⬆️
Sources/ParseSwift/Objects/ParseUser.swift 81.49% <100.00%> (-0.03%) ⬇️
Sources/ParseSwift/Objects/ParseObject.swift 77.39% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7af659b...80dfa9d. Read the comment docs.

@cbaker6 cbaker6 merged commit fca7ab1 into main Jul 5, 2021
@cbaker6 cbaker6 deleted the signup branch July 5, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParseUser.current does not have fields set after .signup(), but it has after .login()
1 participant