Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't query server when limit is zero #189

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Don't query server when limit is zero #189

merged 1 commit into from
Jul 9, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jul 9, 2021

When a query has a limit of zero, there's no need to send the information to the server.

  • Add check for limit zero
  • Fixed a bug in countExplain query where the return type wan't an array
  • Add test cases

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #189 (bd188c1) into main (fca7ab1) will increase coverage by 0.20%.
The diff coverage is 100.00%.

❗ Current head bd188c1 differs from pull request most recent head e7cb9b1. Consider uploading reports for the commit e7cb9b1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   82.47%   82.67%   +0.20%     
==========================================
  Files          71       71              
  Lines        6755     6823      +68     
==========================================
+ Hits         5571     5641      +70     
+ Misses       1184     1182       -2     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/Query+combine.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/Types/Query.swift 94.43% <100.00%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fca7ab1...e7cb9b1. Read the comment docs.

@cbaker6 cbaker6 merged commit 87c4367 into main Jul 9, 2021
@cbaker6 cbaker6 deleted the limit branch July 9, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant