Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct auth keys for Facebook and Twitter login #202

Merged
merged 5 commits into from Jul 30, 2021

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jul 29, 2021

Closes #201.

Sets correct payload for FB login.

@cbaker6
Copy link
Contributor

cbaker6 commented Jul 29, 2021

Though this will work, it uncovers a deeper issue. The Keys should be encoded instead of using the coding keys directly

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #202 (f28df2e) into main (252df53) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   83.31%   83.29%   -0.03%     
==========================================
  Files          76       76              
  Lines        7206     7206              
==========================================
- Hits         6004     6002       -2     
- Misses       1202     1204       +2     
Impacted Files Coverage Δ
...Swift/Authentication/3rd Party/ParseFacebook.swift 100.00% <ø> (ø)
...eSwift/Authentication/3rd Party/ParseTwitter.swift 100.00% <ø> (ø)
Sources/ParseSwift/Coding/AnyEncodable.swift 61.18% <0.00%> (-0.66%) ⬇️
Sources/ParseSwift/Objects/ParseObject.swift 78.09% <0.00%> (-0.26%) ⬇️
Sources/ParseSwift/Types/Query.swift 94.95% <0.00%> (-0.16%) ⬇️
Sources/ParseSwift/Objects/ParseUser.swift 82.89% <0.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 252df53...f28df2e. Read the comment docs.

@cbaker6
Copy link
Contributor

cbaker6 commented Jul 30, 2021

Can you add a change log entry?

@cbaker6 cbaker6 changed the title fix: set access_token for Facebook login fix: use correct auth keys for Facebook and Twitter login Jul 30, 2021
@cbaker6
Copy link
Contributor

cbaker6 commented Jul 30, 2021

LGTM thanks for the fixes!

@cbaker6 cbaker6 merged commit 3e5459d into parse-community:main Jul 30, 2021
@dblythy
Copy link
Member Author

dblythy commented Jul 30, 2021

Thank you @cbaker6!

@dblythy dblythy deleted the fix-fb branch July 30, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParseFacebook sets accessToken instead of access_token
2 participants