Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ParseObject's now conform to Identifiable #254

Merged
merged 19 commits into from
Oct 9, 2021
Merged

feat: ParseObject's now conform to Identifiable #254

merged 19 commits into from
Oct 9, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Oct 8, 2021

New Pull Request Checklist

Issue Description

Support Identifiable natively for ParseObject's and remove support for older OS's, iOS 12, tvOS 12, watchOS 5, and macOS 10.13/14.

Adds configuration option to delete Keychain on app first run. This option is disabled by default and should only be enabled after the following in order to avoid users having to re-login:

  1. Update to Swift SDK 2.0.0
  2. Run/open the Swift SDK based app at least 1 time
  3. Then enable the setting:
let newConfiguration = ParseConfiguration(applicationId: "applicationId",
                                                      serverURL: server,
                                                      deleteKeychainIfNeeded: false)
ParseSwift.initialize(configuration: newConfiguration)

Related issue: #255, #246

Approach

Bump minimum version numbers and remove code checks for unsupported version types.

TODOs before merging

  • Remove all references to old OS availability
  • Remove LocallyIdentifiable protocol and replace with Identifiable for ParseFile
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #254 (cf27146) into main (85366e6) will increase coverage by 0.07%.
The diff coverage is 81.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   76.67%   76.74%   +0.07%     
==========================================
  Files          99       98       -1     
  Lines       10382    10403      +21     
==========================================
+ Hits         7960     7984      +24     
+ Misses       2422     2419       -3     
Impacted Files Coverage Δ
...tion/3rd Party/ParseApple/ParseApple+combine.swift 100.00% <ø> (ø)
...rd Party/ParseFacebook/ParseFacebook+combine.swift 100.00% <ø> (ø)
...cation/3rd Party/ParseLDAP/ParseLDAP+combine.swift 100.00% <ø> (ø)
.../3rd Party/ParseTwitter/ParseTwitter+combine.swift 100.00% <ø> (ø)
...thentication/Internal/ParseAnonymous+combine.swift 100.00% <ø> (ø)
...cation/Protocols/ParseAuthentication+combine.swift 85.71% <ø> (ø)
...Authentication/Protocols/ParseAuthentication.swift 70.98% <ø> (ø)
Sources/ParseSwift/LiveQuery/LiveQuerySocket.swift 59.80% <ø> (ø)
.../ParseSwift/LiveQuery/ParseLiveQuery+combine.swift 72.72% <ø> (ø)
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 73.08% <ø> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85366e6...cf27146. Read the comment docs.

@cbaker6 cbaker6 linked an issue Oct 8, 2021 that may be closed by this pull request
4 tasks
@cbaker6 cbaker6 linked an issue Oct 9, 2021 that may be closed by this pull request
4 tasks
@cbaker6 cbaker6 merged commit 1385abf into main Oct 9, 2021
@cbaker6 cbaker6 deleted the removeIOS12 branch October 9, 2021 18:24
@cbaker6 cbaker6 changed the title ParseObject's now conform to Identifiable feat: ParseObject's now conform to Identifiable Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant