-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ParseObject's now conform to Identifiable #254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #254 +/- ##
==========================================
+ Coverage 76.67% 76.74% +0.07%
==========================================
Files 99 98 -1
Lines 10382 10403 +21
==========================================
+ Hits 7960 7984 +24
+ Misses 2422 2419 -3
Continue to review full report at Codecov.
|
4 tasks
4 tasks
Conflicts: ParseSwift.podtemplate
4 tasks
cbaker6
changed the title
ParseObject's now conform to Identifiable
feat: ParseObject's now conform to Identifiable
Oct 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
Support
Identifiable
natively forParseObject
's and remove support for older OS's, iOS 12, tvOS 12, watchOS 5, and macOS 10.13/14.Adds configuration option to delete Keychain on app first run. This option is disabled by default and should only be enabled after the following in order to avoid users having to re-login:
2.0.0
Related issue: #255, #246
Approach
Bump minimum version numbers and remove code checks for unsupported version types.
TODOs before merging
LocallyIdentifiable
protocol and replace withIdentifiable
forParseFile