Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Parse ViewModels properties always dispatch to the main queue #260

Merged
merged 1 commit into from Oct 17, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Oct 17, 2021

New Pull Request Checklist

Issue Description

If a background task updates a Parse View Model property on the background queue, it's possible that the View connected to the property never displays the update or demonstrates weird behavior.

Related issue: #n/a

Approach

Always dispatch to the main queue when sending out notifications that a View Model property has been updated.

TODOs before merging

  • Add entry to changelog
  • Prepare for release

@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #260 (9eab08a) into main (3934a45) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   76.79%   76.83%   +0.03%     
==========================================
  Files          98       98              
  Lines       10421    10437      +16     
==========================================
+ Hits         8003     8019      +16     
  Misses       2418     2418              
Impacted Files Coverage Δ
Sources/ParseSwift/LiveQuery/Subscription.swift 68.35% <100.00%> (+2.60%) ⬆️
Sources/ParseSwift/Types/CloudViewModel.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/Types/QueryViewModel.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3934a45...9eab08a. Read the comment docs.

@cbaker6 cbaker6 merged commit 2bda2fd into main Oct 17, 2021
@cbaker6 cbaker6 deleted the viewModelProperties branch October 17, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant