Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async/await methods should be available for watchOS 8+ #265

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Oct 25, 2021

New Pull Request Checklist

Issue Description

Related issue: #n/a

Approach

Make methods match concurrency methods in OS

TODOs before merging

  • Add entry to changelog
  • Prepare for release

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 25, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #265 (e07b2c8) into main (d6be35b) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   82.29%   82.34%   +0.04%     
==========================================
  Files          99       99              
  Lines       10512    10512              
==========================================
+ Hits         8651     8656       +5     
+ Misses       1861     1856       -5     
Impacted Files Coverage Δ
...cation/3rd Party/ParseApple/ParseApple+async.swift 100.00% <ø> (ø)
.../3rd Party/ParseFacebook/ParseFacebook+async.swift 100.00% <ø> (ø)
...tication/3rd Party/ParseLDAP/ParseLDAP+async.swift 100.00% <ø> (ø)
...on/3rd Party/ParseTwitter/ParseTwitter+async.swift 100.00% <ø> (ø)
...Authentication/Internal/ParseAnonymous+async.swift 100.00% <ø> (ø)
...tication/Protocols/ParseAuthentication+async.swift 85.71% <ø> (ø)
...es/ParseSwift/LiveQuery/ParseLiveQuery+async.swift 72.72% <ø> (ø)
...s/ParseSwift/Objects/ParseInstallation+async.swift 100.00% <ø> (ø)
Sources/ParseSwift/Objects/ParseObject+async.swift 100.00% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser+async.swift 100.00% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6be35b...e07b2c8. Read the comment docs.

@cbaker6 cbaker6 merged commit 5860abd into main Oct 25, 2021
@cbaker6 cbaker6 deleted the watchOS branch October 25, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant