Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ParsePointer async fetch #271

Merged
merged 5 commits into from Nov 2, 2021
Merged

feat: add ParsePointer async fetch #271

merged 5 commits into from Nov 2, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Nov 1, 2021

New Pull Request Checklist

Issue Description

Currently missing the ability to fetch a ParsePointer using async/await.

Documentation improvements...

Related issue: #N/A

Approach

Add missing features and improve documentation.

TODOs before merging

  • Add tests
  • Update CI to use macos-latest and Xcode 13.1
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 1, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@cbaker6 cbaker6 marked this pull request as draft November 1, 2021 15:00
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #271 (f19cde0) into main (321905d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
+ Coverage   82.31%   82.34%   +0.03%     
==========================================
  Files         100      102       +2     
  Lines       10518    10525       +7     
==========================================
+ Hits         8658     8667       +9     
+ Misses       1860     1858       -2     
Impacted Files Coverage Δ
...urces/ParseSwift/Objects/ParseObject+combine.swift 100.00% <ø> (ø)
Sources/ParseSwift/Operations/ParseOperation.swift 82.59% <ø> (ø)
Sources/ParseSwift/Types/ParseFile+async.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/ParseFile+combine.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/Pointer.swift 78.33% <ø> (-2.27%) ⬇️
Sources/ParseSwift/Types/Pointer+async.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/Types/Pointer+combine.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseUser.swift 79.85% <0.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321905d...f19cde0. Read the comment docs.

@cbaker6 cbaker6 changed the title docs: update documentation feat: add ParsePointer async fetch Nov 1, 2021
@cbaker6 cbaker6 marked this pull request as ready for review November 2, 2021 21:08
@cbaker6 cbaker6 merged commit a64726f into main Nov 2, 2021
@cbaker6 cbaker6 deleted the docNits branch November 2, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant