Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overload QueryConstraint to accept Pointer<ParseObject> #281

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Nov 16, 2021

New Pull Request Checklist

Issue Description

Currently developer can't create a query to compare against a pointer directly. Similarly, the related query can't take a ParseObject directly.

In addition, add os(Windows) so SDK compiles correctly for Windows.

Related issue: #n/a

Approach

Make SDK easier to use by taking a pointer directly.

TODOs before merging

  • Add tests
  • Add os(Windows) so SDK compiles correctly for Windows.
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 16, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #281 (deea8f3) into main (25b70d9) will increase coverage by 0.02%.
The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   82.21%   82.23%   +0.02%     
==========================================
  Files         104      104              
  Lines       10574    10572       -2     
==========================================
+ Hits         8693     8694       +1     
+ Misses       1881     1878       -3     
Impacted Files Coverage Δ
...eSwift/InternalObjects/BaseParseInstallation.swift 36.36% <0.00%> (ø)
Sources/ParseSwift/LiveQuery/LiveQuerySocket.swift 59.80% <ø> (ø)
...es/ParseSwift/LiveQuery/ParseLiveQuery+async.swift 72.72% <ø> (ø)
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 73.08% <ø> (ø)
...t/LiveQuery/Protocols/ParseLiveQueryDelegate.swift 14.28% <ø> (ø)
Sources/ParseSwift/Storage/KeychainStore.swift 95.45% <ø> (ø)
...ources/ParseSwift/Storage/ParseKeyValueStore.swift 91.66% <ø> (ø)
Sources/ParseSwift/Extensions/URLCache.swift 46.66% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseInstallation.swift 77.48% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseUser.swift 79.93% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25b70d9...deea8f3. Read the comment docs.

@cbaker6 cbaker6 merged commit a121bde into main Nov 16, 2021
@cbaker6 cbaker6 deleted the pointer branch November 16, 2021 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant