Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use default ACL on newly created ParseObjects #284

Merged
merged 4 commits into from Nov 19, 2021
Merged

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Nov 18, 2021

New Pull Request Checklist

Issue Description

Developers currently have to add the defaultACL to their ParseObject's. The SDK should be able to handle this.

Related issue: #n/a

Approach

Check if there is currently no ACL set on an object, if there's non, but there's a default ACL available, use it. This occurs before saving/creating an object to the server.

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 18, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #284 (4c10058) into main (863781b) will increase coverage by 0.21%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   82.23%   82.44%   +0.21%     
==========================================
  Files         104      104              
  Lines       10572    10596      +24     
==========================================
+ Hits         8694     8736      +42     
+ Misses       1878     1860      -18     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/ParseACL.swift 85.33% <79.16%> (-0.97%) ⬇️
Sources/ParseSwift/Coding/ParseEncoder.swift 73.82% <92.00%> (+0.21%) ⬆️
Sources/ParseSwift/API/API+Command.swift 84.18% <100.00%> (+0.20%) ⬆️
Sources/ParseSwift/Objects/ParseInstallation.swift 77.63% <100.00%> (+0.14%) ⬆️
Sources/ParseSwift/Objects/ParseObject.swift 76.01% <100.00%> (+1.10%) ⬆️
Sources/ParseSwift/Objects/ParseUser.swift 80.04% <100.00%> (+0.10%) ⬆️
Sources/ParseSwift/API/API.swift 100.00% <0.00%> (+2.81%) ⬆️
Sources/ParseSwift/Objects/ParseRole.swift 100.00% <0.00%> (+17.77%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 863781b...4c10058. Read the comment docs.

@cbaker6 cbaker6 merged commit b4bdfb1 into main Nov 19, 2021
@cbaker6 cbaker6 deleted the defaultACL branch November 19, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant