New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ParseGeoPoint convenience methods for CoreLocation #287
Conversation
Added Path variable fix for M1 Mac's see: https://www.anotheriosdevblog.com/installing-swiftlint-on-a-m1/
Thanks for opening this pull request!
|
@jaysonng thanks for opening your first PR on the repo! Be sure to take note of the updates I made to the description. You will want to only add text where the comments ask it. Does your changes make swiftlint work on your M1? I don’t have one to test. |
adding toCLLocation and toCLLocationCoordinate2D convenience methods and Tests.
Codecov Report
@@ Coverage Diff @@
## main #287 +/- ##
==========================================
+ Coverage 82.44% 82.46% +0.01%
==========================================
Files 104 104
Lines 10596 10607 +11
==========================================
+ Hits 8736 8747 +11
Misses 1860 1860
Continue to review full report at Codecov.
|
You will need to fix the Linux build by ensuring #if canImport(CoreLocation)
#endif |
yes, i had to get it to work so i can test it on the ParseSwift updates I'm making. this was my fix. |
im so confused right now. How come my pull request for the CoreLocation methods and tests are showing up on this PR for SwiftLint? seems like it's because I pushed the new fixes to the my main branch. should I revert, and create a tree? so it has a separate PR? |
…iners Renaming locationCoordate to coordinate and removing return for one liners
Each PR needs to be made from a separate beach. Normally, you would make changes to a branch from the main on your fork for each PR and not to the main main branch directly. |
@mtrezza I will leave this and future PR's on the main so you can test autorelease |
Got it. I'll keep that in mind for the next PR's I do. Thanks. |
New Pull Request Checklist
Issue Description
Currently devs have add their own convenience methods to deal with
CLLocationCoordinate2D
.Also fixes SwiftLint not working for M1 Macs
Related issue: #286
Approach
Add
toCLLocation
andtoCLLocationCoordinate2D
for easy conversion from aParseGeoPoint
object.SwiftLint: Based on https://www.anotheriosdevblog.com/installing-swiftlint-on-a-m1/, added the script to the existing SwiftLint script.
TODOs before merging