Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query objects doesn't dispatch properly #293

Merged
merged 1 commit into from Nov 30, 2021
Merged

fix: query objects doesn't dispatch properly #293

merged 1 commit into from Nov 30, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Nov 30, 2021

New Pull Request Checklist

Issue Description

Changes in #291 refactored important asynchronous callbacks. There was one missed which can cause a crash while querying.

Related issue: #n/a

Approach

After querying the server, be sure to dispatch back to the proper queue

TODOs before merging

  • Add fix
  • Add entry to changelog

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 30, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #293 (7a5d714) into main (4734212) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   82.36%   82.36%           
=======================================
  Files         104      104           
  Lines       10659    10666    +7     
=======================================
+ Hits         8779     8785    +6     
- Misses       1880     1881    +1     
Impacted Files Coverage Δ
...urces/ParseSwift/API/API+NonParseBodyCommand.swift 75.79% <100.00%> (+0.31%) ⬆️
Sources/ParseSwift/Objects/ParseUser.swift 79.97% <0.00%> (-0.13%) ⬇️
...Authentication/Protocols/ParseAuthentication.swift 72.16% <0.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4734212...7a5d714. Read the comment docs.

@cbaker6 cbaker6 merged commit 79b760f into parse-community:main Nov 30, 2021
@cbaker6 cbaker6 deleted the queueIssue branch November 30, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant