Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let additional headers take any type #302

Merged
merged 5 commits into from
Dec 13, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Dec 13, 2021

New Pull Request Checklist

Issue Description

Additional headers should be able to take a dictionary of [AnyHashable: Any] as specified by https://developer.apple.com/documentation/foundation/urlsessionconfiguration/1411532-httpadditionalheaders

Related issue: #n/a

Approach

Let additional headers accept [AnyHashable: Any].

TODOs before merging

  • Add tests
  • Refactor URLCache with less code

@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 13, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #302 (7e4f92d) into main (a15114b) will increase coverage by 0.08%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
+ Coverage   83.61%   83.70%   +0.08%     
==========================================
  Files         105      105              
  Lines       11168    11154      -14     
==========================================
- Hits         9338     9336       -2     
+ Misses       1830     1818      -12     
Impacted Files Coverage Δ
Sources/ParseSwift/Parse.swift 98.75% <ø> (ø)
Sources/ParseSwift/Extensions/URLCache.swift 77.77% <90.00%> (+31.11%) ⬆️
Sources/ParseSwift/Objects/ParseUser.swift 80.69% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15114b...7e4f92d. Read the comment docs.

@cbaker6 cbaker6 merged commit 847bdf8 into parse-community:main Dec 13, 2021
@cbaker6 cbaker6 deleted the additionalHeaders branch December 13, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant