Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add score property, withCount, and matchesText options #306

Merged
merged 5 commits into from Jan 1, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jan 1, 2022

New Pull Request Checklist

Issue Description

Related issue: #n/a

Approach

Add the capabilities mentioned above similar to the JS SDK implementations. Examples of how the new features can be used are in the modified Swift Playground files.

A breaking change is introduced because score should be a reserved property that can' be modified by developers. The compiler with assist developers in addressing the change by recommending var score: Double? be added to all ParseObject's.

Changes you will need to make:

  • Add var score: Double? to all ParseObject's

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 1, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Jan 1, 2022

Codecov Report

Merging #306 (767eee6) into main (aa8b027) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   83.78%   83.95%   +0.17%     
==========================================
  Files         105      105              
  Lines       11154    11256     +102     
==========================================
+ Hits         9345     9450     +105     
+ Misses       1809     1806       -3     
Impacted Files Coverage Δ
...eSwift/InternalObjects/BaseParseInstallation.swift 36.36% <ø> (ø)
Sources/ParseSwift/Objects/ParseObject.swift 81.46% <ø> (ø)
...rces/ParseSwift/Protocols/ParseObjectMutable.swift 100.00% <ø> (ø)
Sources/ParseSwift/Protocols/Queryable.swift 0.00% <ø> (ø)
Sources/ParseSwift/Coding/ParseEncoder.swift 74.23% <100.00%> (+0.35%) ⬆️
Sources/ParseSwift/Types/Query+async.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/Types/Query+combine.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/Types/Query.swift 93.17% <100.00%> (+0.56%) ⬆️
Sources/ParseSwift/Types/QueryConstraint.swift 97.50% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8b027...767eee6. Read the comment docs.

Conflicts:
	ParseSwift.playground/Pages/2 - Finding Objects.xcplaygroundpage/Contents.swift
@cbaker6 cbaker6 merged commit 3bf2471 into parse-community:main Jan 1, 2022
@cbaker6 cbaker6 deleted the queryUpdates branch January 1, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant