Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds equalTo QueryConstraint along which uses $eq #310

Merged
merged 11 commits into from Jan 3, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jan 3, 2022

New Pull Request Checklist

Issue Description

$eq was removed in a #49 which allowed for multiple QueryConstraint's to be used on a single key, though it's currently not supported by the LiveQuery server.

Related issue: #n/a

Approach

Adds equalTo QueryConstraint along with ability to change the SDK default behavior of using $eq QueryConstraint parameter or not.

TODOs before merging

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 3, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #310 (3b9608c) into main (4c611ac) will decrease coverage by 0.06%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
- Coverage   84.63%   84.57%   -0.07%     
==========================================
  Files         114      114              
  Lines       11701    11718      +17     
==========================================
+ Hits         9903     9910       +7     
- Misses       1798     1808      +10     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/QueryConstraint.swift 95.71% <88.23%> (-1.28%) ⬇️
Sources/ParseSwift/Parse.swift 98.77% <100.00%> (+0.02%) ⬆️
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 72.92% <0.00%> (-0.60%) ⬇️
Sources/ParseSwift/Objects/ParseUser.swift 80.50% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c611ac...3b9608c. Read the comment docs.

@cbaker6 cbaker6 merged commit e9ba846 into parse-community:main Jan 3, 2022
@cbaker6 cbaker6 deleted the eqConstraint branch January 3, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant