Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update config init parameter names #323

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jan 19, 2022

New Pull Request Checklist

Issue Description

The server configuration init parameter names don't match style.

Related issue: #n/a

Approach

Update the server configuration init parameter names to match style

TODOs before merging

  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 19, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #323 (a3c6820) into main (a828f82) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
- Coverage   85.01%   84.96%   -0.05%     
==========================================
  Files         114      114              
  Lines       12048    12048              
==========================================
- Hits        10243    10237       -6     
- Misses       1805     1811       +6     
Impacted Files Coverage Δ
Sources/ParseSwift/Parse.swift 98.77% <100.00%> (ø)
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 72.92% <0.00%> (-0.60%) ⬇️
Sources/ParseSwift/Objects/ParseUser.swift 82.43% <0.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a828f82...a3c6820. Read the comment docs.

@cbaker6 cbaker6 merged commit 054a226 into parse-community:main Jan 20, 2022
@cbaker6 cbaker6 deleted the configNames branch January 20, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant