Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump SPM toolchain to 5.5 #326

Merged
merged 4 commits into from
Jan 22, 2022
Merged

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jan 22, 2022

New Pull Request Checklist

Issue Description

The Package.swift currently specifies 5.1 as the tool version, preventing the SDK and developers to take advantage of the latest features of the 5.5 toolchain such as DocC and tutorials.

Related issue: #n/a

Approach

Bump the SPM toolchain to 5.5. This will benefit developers using Xcode 13+ as they will be able to access the docs and tutorials when building their apps in Xcode along with those using SPM on Linux, Android, and Windows.

Breaking Change for those developers who want to use ParseSwift 4.0.0+ with < Xcode 13 and depend on the SDK using SPM. These developers should either update their Xcode to 13+ or will need to use Cocoapods or Carthage to depend on the Swift SDK for now on.

TODOs before merging

  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 22, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #326 (923b651) into main (7cbf97b) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   85.02%   84.99%   -0.04%     
==========================================
  Files         114      114              
  Lines       12048    12048              
==========================================
- Hits        10244    10240       -4     
- Misses       1804     1808       +4     
Impacted Files Coverage Δ
Sources/ParseSwift/Objects/ParseObject.swift 81.98% <0.00%> (-0.31%) ⬇️
Sources/ParseSwift/Objects/ParseUser.swift 82.43% <0.00%> (-0.19%) ⬇️
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 73.52% <0.00%> (-0.15%) ⬇️
Sources/ParseSwift/Types/ParseAnalytics.swift 98.72% <0.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cbf97b...923b651. Read the comment docs.

@cbaker6 cbaker6 merged commit 5966a4c into parse-community:main Jan 22, 2022
@cbaker6 cbaker6 deleted the spmTools branch January 22, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant