Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add variadic QueryConstraint methods #345

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Feb 25, 2022

New Pull Request Checklist

Issue Description

Currently the only way to create or, nor, and and Query's is by passing in an array of queries. There's no ability to pass a variadic amount of queries.

Related issue: #n/a

Approach

Add variadic methods that call through to the array methods.

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 25, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #345 (0bc350b) into main (a34c5cb) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   85.18%   85.22%   +0.04%     
==========================================
  Files         114      114              
  Lines       12198    12207       +9     
==========================================
+ Hits        10391    10404      +13     
+ Misses       1807     1803       -4     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/ParsePolygon.swift 93.81% <ø> (ø)
Sources/ParseSwift/Types/QueryConstraint.swift 95.84% <100.00%> (+0.13%) ⬆️
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 73.63% <0.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a34c5cb...0bc350b. Read the comment docs.

@cbaker6 cbaker6 merged commit 4d2d509 into parse-community:main Feb 25, 2022
@cbaker6 cbaker6 deleted the variadocQ branch February 25, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant