Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop support for Swift 5.2 #356

Merged
merged 8 commits into from
Apr 17, 2022
Merged

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Apr 13, 2022

New Pull Request Checklist

Issue Description

Swift 5.2 and Xcode 11 isn't supported by the AppStore anymore per Apple:

iPhone and iPad apps. Starting April 26, 2021, all iPhone and iPad apps submitted to the App Store must be built with Xcode 12 and the iOS 14 SDK or later. The iOS SDK provides access to exciting new features like App Clips, Home screen widgets, ARKit, RealityKit, and much more.

Dropping support for 5.2 allows the SDK to be designed with the latest advancements of 5.3+; particularly:

  • availability of self (the SDK is currently designed to use self a specific way because of 5.2)
  • key paths (the SDK is currently designed to not use keyPath's as functions because of 5.2)
  • much more

SwiftPackageIndex has also stopped building Swift 5.2 and only builds Swift 5.3+: https://swiftpackageindex.com/parse-community/Parse-Swift/builds

Related issue: #n/a

Approach

Remove Swift 5.2 from CI along with any related compiler checks.

TODOs before merging

  • Add entry to changelog

@parse-github-assistant
Copy link

parse-github-assistant bot commented Apr 13, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #356 (b421ebf) into main (2cb662a) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   88.00%   87.90%   -0.11%     
==========================================
  Files         114      114              
  Lines       12209    12198      -11     
==========================================
- Hits        10745    10723      -22     
- Misses       1464     1475      +11     
Impacted Files Coverage Δ
Sources/ParseSwift/Extensions/Data.swift 58.33% <ø> (-41.67%) ⬇️
Sources/ParseSwift/Objects/ParseUser+async.swift 100.00% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser+combine.swift 95.55% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser.swift 86.20% <ø> (ø)
Sources/ParseSwift/Coding/ParseEncoder.swift 77.31% <0.00%> (-0.46%) ⬇️
Sources/ParseSwift/Objects/ParseObject.swift 85.19% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb662a...b421ebf. Read the comment docs.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Apr 13, 2022

@mtrezza can you remove spm-test-5_2 and xcode-test-earliest as a requirement for the CI?

@cbaker6 cbaker6 merged commit c57fc2e into parse-community:main Apr 17, 2022
@cbaker6 cbaker6 deleted the swift5.2 branch April 17, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant