Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add query computed property to ParseObject #365

Merged
merged 3 commits into from May 18, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented May 18, 2022

New Pull Request Checklist

Issue Description

There's currently no computed property .query on ParseObjects, the only way to get this is by using .query.

Related issue: #n/a

Approach

Add .query computed property to ParseObject and add a default value to query(_ constraints: [QueryConstraint] = []) to ensure .query() still works and doesn't break the SDK.

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #365 (97ef6ea) into main (630ee91) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   87.92%   87.91%   -0.01%     
==========================================
  Files         114      114              
  Lines       12207    12207              
==========================================
- Hits        10733    10732       -1     
- Misses       1474     1475       +1     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/Query.swift 94.37% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseObject.swift 85.03% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 630ee91...97ef6ea. Read the comment docs.

@cbaker6 cbaker6 merged commit 5a2c5fd into parse-community:main May 18, 2022
@cbaker6 cbaker6 deleted the queryProperty branch May 18, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant