Bug fix: issue when encoding objects that are already saved #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmmlo thanks for filing this issue. It was definitely a corner case that wasn't easy to find. Can you test this out in your scenarios and left me know if you see any other issues. You should try to run other scenarios that you know use to work as well. |
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 76.63% 76.65% +0.02%
==========================================
Files 42 42
Lines 3757 3757
==========================================
+ Hits 2879 2880 +1
+ Misses 878 877 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47. Previous commits didn't enforce
ParseObjectsgoing through the ParseEncoder. Since they go through now, there was a bug in the encoder when objects were already saved. They were automatically converted to Pointers, even if they were themselves. This caused issues when attempting to saveAll as 1) there were keys the server didn't like 2) No other key/value info wasn't being sent during the update