Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux support #59

Merged
merged 16 commits into from
Jan 23, 2021
Merged

Linux support #59

merged 16 commits into from
Jan 23, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jan 23, 2021

Builds on Linux!

  • Add Linux build to CI
  • Add Linux test to CI (commented out because of issues below)

The testsuite has revealed the following limitations on Linux:

  • ParseFile currently doesn't work. This is because the SDK is currently setup for iOS, macOS, etc. There's probably a simple way to access the file system on Linux via Swift that can be added at some point.
  • ParseLiveQuery currently doesn't work in the latest version of Swift (5.3.2). FoundationNetworking doesn't have URLWebSocketSessionTask. The solution is to wait to for web socket support to be added in a newer version of Swift.
  • Keychain currently doesn't work in the latest version of Swift (5.3.2). The workaround for this has already been added in the SDK. Devs need to conform to ParseKeyValueStore if they want to persist the current user, installation, and config. Otherwise they only exist in memory while the SDK is running.
  • The XCTest suite for linux doesn't seem to like comparing optionals, which is an issue because of the way the tests are currently setup.
  • Only works on Swift 5.3+, < Swift 5.3 is missing important features needed by the ParseEncoder.

@cbaker6 cbaker6 marked this pull request as draft January 23, 2021 14:22
@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #59 (69a4fc4) into main (cb26d0f) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   77.95%   77.97%   +0.02%     
==========================================
  Files          51       51              
  Lines        4577     4577              
==========================================
+ Hits         3568     3569       +1     
+ Misses       1009     1008       -1     
Impacted Files Coverage Δ
...t/LiveQuery/Protocols/ParseLiveQueryDelegate.swift 20.00% <ø> (ø)
Sources/ParseSwift/Objects/ParseObject.swift 76.31% <0.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb26d0f...69a4fc4. Read the comment docs.

@cbaker6 cbaker6 marked this pull request as ready for review January 23, 2021 16:26
@cbaker6 cbaker6 merged commit f66d84d into main Jan 23, 2021
@cbaker6 cbaker6 deleted the linux branch January 23, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant