Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LDAP authentication #79

Merged
merged 3 commits into from
Feb 14, 2021
Merged

Add LDAP authentication #79

merged 3 commits into from
Feb 14, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Feb 14, 2021

  • add ParseLDAP
  • Documentation
  • Tests
  • Fixed a bug that would have prevented unlinking new auths and accidentally unlinking the Apple auth

@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #79 (7053918) into main (ffa070f) will decrease coverage by 0.01%.
The diff coverage is 77.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   79.13%   79.11%   -0.02%     
==========================================
  Files          62       63       +1     
  Lines        4936     5018      +82     
==========================================
+ Hits         3906     3970      +64     
- Misses       1030     1048      +18     
Impacted Files Coverage Δ
...rseSwift/Authentication/3rd Party/ParseApple.swift 75.64% <ø> (ø)
...arseSwift/Authentication/3rd Party/ParseLDAP.swift 75.64% <75.64%> (ø)
...Authentication/Protocols/ParseAuthentication.swift 73.73% <100.00%> (+1.10%) ⬆️
Sources/ParseSwift/Objects/ParseObject.swift 76.23% <0.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffa070f...d41bdb2. Read the comment docs.

@cbaker6 cbaker6 requested a review from TomWFox February 14, 2021 18:42
@cbaker6
Copy link
Contributor Author

cbaker6 commented Feb 14, 2021

@TomWFox can you check the docs on this one?

@cbaker6
Copy link
Contributor Author

cbaker6 commented Feb 14, 2021

Followed the process in #55

Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM 👍

@cbaker6 cbaker6 merged commit 0d81cd4 into main Feb 14, 2021
@cbaker6 cbaker6 deleted the ldap branch February 14, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants