-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Twitter and Facebook login #97
Conversation
Codecov Report
@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 79.76% 80.66% +0.90%
==========================================
Files 63 65 +2
Lines 5170 5411 +241
==========================================
+ Hits 4124 4365 +241
Misses 1046 1046
Continue to review full report at Codecov.
|
Thanks @abs8090 for your contribution! I will look over soon. In the mean time can you add an entry to the CHANGELOG.md file, something like (this should go right above
|
Sources/ParseSwift/Authentication/3rd Party/ParseFacebook.swift
Outdated
Show resolved
Hide resolved
Sources/ParseSwift/Authentication/3rd Party/ParseFacebook.swift
Outdated
Show resolved
Hide resolved
Sources/ParseSwift/Authentication/3rd Party/ParseFacebook.swift
Outdated
Show resolved
Hide resolved
Sources/ParseSwift/Authentication/3rd Party/ParseFacebook.swift
Outdated
Show resolved
Hide resolved
Sources/ParseSwift/Authentication/3rd Party/ParseFacebook.swift
Outdated
Show resolved
Hide resolved
Sources/ParseSwift/Authentication/3rd Party/ParseFacebook.swift
Outdated
Show resolved
Hide resolved
Sources/ParseSwift/Authentication/3rd Party/ParseFacebook.swift
Outdated
Show resolved
Hide resolved
Sources/ParseSwift/Authentication/3rd Party/ParseFacebook.swift
Outdated
Show resolved
Hide resolved
Sources/ParseSwift/Authentication/3rd Party/ParseFacebook.swift
Outdated
Show resolved
Hide resolved
Sources/ParseSwift/Authentication/3rd Party/ParseFacebook.swift
Outdated
Show resolved
Hide resolved
Sources/ParseSwift/Authentication/3rd Party/ParseFacebook.swift
Outdated
Show resolved
Hide resolved
Sources/ParseSwift/Authentication/3rd Party/ParseFacebook.swift
Outdated
Show resolved
Hide resolved
I updated your branch with the latest main, you should should |
accepted all suggested changes Co-authored-by: Corey <coreyearleon@icloud.com>
The PR is looking good! Be sure to "pull" your branch again before making anymore updates. You had some inconsistencies in ParseTwitter with, Things you need to do:
|
This looks ready to go! Thanks for making your first contribution! |
This PR adds Twitter and Facebook login via the ParseAuthenticatable protocol.
The user of ParseTwitter or ParseFacebook still needs to implement TwitterKit or FBSDKCoreKit to obtain authentication keys and pass them to ParseTwitter.logn() or ParseFacebook.login() to authenticate with ParseServer.