Merge pull request #146 from ParsePlatform/nlutsenko.extensions

Make ParseUI fully compile from source for app extensions.
parse-community · Sep 8, 2015 · 1a6f669 · 1a6f669
2 parents 8767f4d + 5e054b4
commit 1a6f669
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 12 deletions.
diff --git a/ParseUI/Classes/LogInViewController/PFLogInViewController.m b/ParseUI/Classes/LogInViewController/PFLogInViewController.m
@@ -288,7 +288,7 @@ - (void)_dismissAction {
     [self dismissViewControllerAnimated:YES completion:nil];
 }
 
-- (void)_forgotPasswordAction {
+- (void)_forgotPasswordAction PF_EXTENSION_UNAVAILABLE("") {
     NSString *title = NSLocalizedString(@"Reset Password", @"Forgot password request title in PFLogInViewController");
     NSString *message = NSLocalizedString(@"Please enter the email address for your account.",
                                           @"Email request message in PFLogInViewController");

diff --git a/ParseUI/Classes/QueryCollectionViewController/PFQueryCollectionViewController.m b/ParseUI/Classes/QueryCollectionViewController/PFQueryCollectionViewController.m
@@ -399,11 +399,13 @@ - (void)_handleDeletionError:(NSError *)error {
 
         [self presentViewController:errorController animated:YES completion:nil];
     } else {
-        UIAlertView *alertView = [[UIAlertView alloc] initWithTitle:NSLocalizedString(@"Error", @"Error")
-                                                            message:errorMessage
-                                                           delegate:nil
-                                                  cancelButtonTitle:NSLocalizedString(@"OK", @"OK")
-                                                  otherButtonTitles:nil];
+        // Cast to `id` is required for building succesfully for app extensions,
+        // this code actually never runs in App Extensions, since they are iOS 8.0+, so we are good with just a hack
+        UIAlertView *alertView = [(id)[UIAlertView alloc] initWithTitle:NSLocalizedString(@"Error", @"Error")
+                                                                message:errorMessage
+                                                               delegate:nil
+                                                      cancelButtonTitle:NSLocalizedString(@"OK", @"OK")
+                                                      otherButtonTitles:nil];
 
         [alertView show];
     }

diff --git a/ParseUI/Classes/QueryTableViewController/PFQueryTableViewController.m b/ParseUI/Classes/QueryTableViewController/PFQueryTableViewController.m
@@ -398,7 +398,7 @@ - (void)removeObjectsAtIndexPaths:(NSArray *)indexPaths animated:(BOOL)animated
     }
 
     [[BFTask taskForCompletionOfAllTasks:allDeletionTasks]
-                       continueWithBlock:deletionHandlerBlock];
+     continueWithBlock:deletionHandlerBlock];
 }
 
 - (PFTableViewCell *)tableView:(UITableView *)otherTableView cellForNextPageAtIndexPath:(NSIndexPath *)indexPath {
@@ -531,11 +531,13 @@ - (void)_handleDeletionError:(NSError *)error {
 
         [self presentViewController:errorController animated:YES completion:nil];
     } else {
-        UIAlertView *alertView = [[UIAlertView alloc] initWithTitle:NSLocalizedString(@"Error", @"Error")
-                                                            message:errorMessage
-                                                           delegate:nil
-                                                  cancelButtonTitle:NSLocalizedString(@"OK", @"OK")
-                                                  otherButtonTitles:nil];
+        // Cast to `id` is required for building succesfully for app extensions,
+        // this code actually never runs in App Extensions, since they are iOS 8.0+, so we are good with just a hack
+        UIAlertView *alertView = [(id)[UIAlertView alloc] initWithTitle:NSLocalizedString(@"Error", @"Error")
+                                                                message:errorMessage
+                                                               delegate:nil
+                                                      cancelButtonTitle:NSLocalizedString(@"OK", @"OK")
+                                                      otherButtonTitles:nil];
 
         [alertView show];
     }