Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On first class open column sorting is always descending #1992

Closed
4 tasks done
404-html opened this issue Jan 12, 2022 · 8 comments
Closed
4 tasks done

On first class open column sorting is always descending #1992

404-html opened this issue Jan 12, 2022 · 8 comments
Labels
type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@404-html
Copy link
Member

404-html commented Jan 12, 2022

New Issue Checklist

Issue Description

sorting-problem

Steps to reproduce

  1. Go to data browser;
  2. Browse any class;
  3. Apply ascending sorting on any column;
  4. Switch to different class;
  5. Go back to the previous class;

Actual Outcome

Sorting seems to be descending.

Expected Outcome

Sorting should be ascending.

Environment

Dashboard

  • Parse Dashboard version: 4.0.0-beta.1
  • Browser (Safari, Chrome, Firefox, Edge, etc.): Chrome
  • Browser version: 97.0.4692.71

Server

  • Parse Server version: 4.10.4
  • Operating system: Linux
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): Google Cloud

Database

  • System (MongoDB or Postgres): MongoDB
  • Database version: 4.4.11
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): MongoDB Atlas

Logs

Nothing gets logged in browser' dev tools.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 12, 2022

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@404-html 404-html added the type:bug Impaired feature or lacking behavior that is likely assumed label Jan 12, 2022
@404-html
Copy link
Member Author

Problem still exists on recent 4.0.0-BETA.2.

@mtrezza
Copy link
Member

mtrezza commented Jan 23, 2022

@visualfanatic Would you mind taking a look at this too? It also seems to be related to the changes in context. If that is in fact the case, I think we would need a more thorough review of #1948 to see whether there may be a conceptual issue with the change, or maybe a different pattern that should be applied to more places in that PR.

@damianstasik
Copy link
Contributor

I checked 4.0.0-alpha.4 which was released before the context changes and it seems like data browser behaves the same. Could you confirm that @404-html?

@404-html
Copy link
Member Author

Thanks for checking @visualfanatic, and I can confirm that problem also exists on 4.0.0-alpha.4 version.
I ran git bisect and it pointed following commit: 52c315a
Some of the logic could be indeed asynchronous, which looks kind of strange. Any idea @visualfanatic?

@damianstasik
Copy link
Contributor

@404-html this one should fix the issue: #2016

@AshishBarvaliya
Copy link
Member

@mtrezza Unable to reproduce the issue with the latest versions, indicating that the fix has already been implemented. Can you please verify this and proceed with closing the issue?

@mtrezza
Copy link
Member

mtrezza commented May 1, 2023

Thanks for pointing this out, I assume that #2016 has indeed fixed the issue then.

@mtrezza mtrezza closed this as completed May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Development

No branches or pull requests

4 participants