Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change row batch deletion confirmation entry #2239

Closed
4 tasks done
mtrezza opened this issue Aug 16, 2022 · 5 comments · Fixed by #2319
Closed
4 tasks done

Change row batch deletion confirmation entry #2239

mtrezza opened this issue Aug 16, 2022 · 5 comments · Fixed by #2319
Labels
bounty:$10 Bounty applies for fixing this issue (Parse Bounty Program) type:feature New feature or improvement of existing feature

Comments

@mtrezza
Copy link
Member

mtrezza commented Aug 16, 2022

New Issue Checklist

Issue Description

This is a UX issue. The confirmation dialog to delete selected rows, to delete all rows and to delete the whole class require to enter the class name. All 3 dialogs look similar. The issue is that the dialogs may be mistaken for each other. Also the buttons in the menu to perform these actions are next to each other.

Screen Shot 2022-08-16 at 11 38 04

Screen Shot 2022-08-16 at 11 30 37

Screen Shot 2022-08-16 at 11 24 38

Screen Shot 2022-08-16 at 11 24 28

Steps to reproduce

  1. Delete selected rows
  2. Delete all rows
  3. Delete class

Actual Outcome

Described above

Expected Outcome

Make the dialogs more distinguishable, for example:

  • The dialog to delete N rows should not request to enter the class name but the word "delete selected"
  • The dialog to delete all rows should not request to enter the class name but the word "delete all".
  • The dialog to delete the whole class should stay as is and request to enter the class name.

Environment

Dashboard

  • Parse Dashboard version: 4.1.4

Logs

n/a

@parse-github-assistant
Copy link

parse-github-assistant bot commented Aug 16, 2022

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza added type:feature New feature or improvement of existing feature bounty:$10 Bounty applies for fixing this issue (Parse Bounty Program) labels Aug 16, 2022
@sadakchap
Copy link
Member

@mtrezza Can I please take a stab at this issue?

@mtrezza
Copy link
Member Author

mtrezza commented Oct 13, 2022

Please feel free, it doesn't seem that anyone is working on this as there's no comment

cc @Magdaraa

@sadakchap
Copy link
Member

Thank you @mtrezza . Here's the pr #2319. Please let me know about your thoughts.

@mtrezza mtrezza linked a pull request Oct 15, 2022 that will close this issue
5 tasks
@mtrezza
Copy link
Member Author

mtrezza commented Oct 15, 2022

Closing via #2319

@mtrezza mtrezza closed this as completed Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty:$10 Bounty applies for fixing this issue (Parse Bounty Program) type:feature New feature or improvement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants