Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building on Windows #1115

Merged
merged 4 commits into from
Aug 15, 2019
Merged

Support building on Windows #1115

merged 4 commits into from
Aug 15, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jun 19, 2019

Closes: #1097

@dplewis
Copy link
Member Author

dplewis commented Jun 19, 2019

@oallouch Can you check if this works for you?

@oallouch
Copy link

"npm run dashboard" : the server starts, but it doesn't update when I change a file (I tried to modify the sidebar title in SidebarHeader.react.js)
"npm run build" : seems to work, but I don't see my modification
"npm run pig" : localhost:4041 gives my a blank page

@dplewis
Copy link
Member Author

dplewis commented Jun 20, 2019

npm run dashboard should also call --watch. Did you refresh the browser / clear cache?
npm run pig I ran into the same issue, it will need investigation.

@oallouch
Copy link

ok, "npm run build" does indeed work. I just need to clear the cache.
but --watch doesn't

The PIG issue seems to be module related. Maybe there should be "export default" instead of "module.exports = "

@dplewis dplewis merged commit e3c35a3 into master Aug 15, 2019
@dplewis dplewis deleted the windows-build branch August 15, 2019 00:51
@JeromeDeLeon
Copy link
Contributor

JeromeDeLeon commented Sep 5, 2019

I'm using windows and I just ran npm install and npm run pig then accessed localhost:4041 but got invalid response.
image

@dplewis
Copy link
Member Author

dplewis commented Sep 5, 2019

@JeromeDeLeon Can you open this in a separate issue? It might get lost here.

Also include any error messages you received (inspect). Does npm run dashboard work for you?

@mtrezza mtrezza added type:feature New feature or improvement of existing feature and removed type:improvement labels Dec 6, 2021
@parse-github-assistant
Copy link

The label type:feature cannot be used here.

@parse-github-assistant parse-github-assistant bot removed the type:feature New feature or improvement of existing feature label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't build on Windows
4 participants