Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Database Browser): Cell edit not updating partial view #1255

Conversation

douglasmuraoka
Copy link
Contributor

When users edit a BrowserCell and update its value, for a brief moment they can see the outdated value being rendered, and after the update request completes, the updated value is then rendered. This PR fixes that, by forcing a re-render of the row when editing is done.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit 6f3a4ce into parse-community:master Aug 30, 2019
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Sep 10, 2019
* commit '54ce71875033d8c3309d4f18090ac8336795d4de': (54 commits)
  2.0.1 (parse-community#1264)
  2.0.0 (parse-community#1263)
  Update cross-env to the latest version 🚀 (parse-community#1262)
  Update query-string to the latest version 🚀 (parse-community#1261)
  Update path-to-regexp to the latest version 🚀 (parse-community#1260)
  Update sass-loader to the latest version 🚀 (parse-community#1254)
  fix(Database Browser): Cell edit not updating partial view (parse-community#1255)
  Update eslint to the latest version 🚀 (parse-community#1259)
  Update commander to the latest version 🚀 (parse-community#1257)
  Update eslint-plugin-jest to the latest version 🚀 (parse-community#1256)
  Update graphql to the latest version 🚀 (parse-community#1253)
  refactor(Database Browser): Table performance improvements (parse-community#1241)
  Update parse to the latest version 🚀 (parse-community#1252)
  Update webpack to the latest version 🚀 (parse-community#1251)
  build(deps): bump eslint-utils from 1.4.0 to 1.4.2 (parse-community#1249)
  Update babel-eslint to the latest version 🚀 (parse-community#1245)
  fix: Avoid filter tab disappears on apply filter (parse-community#1229)
  Update graphql to the latest version 🚀 (parse-community#1243)
  Update graphql to the latest version 🚀 (parse-community#1242)
  Update graphql to the latest version 🚀 (parse-community#1240)
  ...

# Conflicts:
#	package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants