Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add descriptive statistics for number cells in data browser #2529

Merged
merged 7 commits into from
Feb 26, 2024

Conversation

AshishBarvaliya
Copy link
Member

@AshishBarvaliya AshishBarvaliya commented Feb 23, 2024

New Pull Request Checklist

Issue Description

Closes: #2506

Approach

  1. Holding down the Shift key while clicking will conveniently highlight the entire area.
  2. Currently, I'm displaying statistics in the toolbar using a default theme. Feel free to share your preferences.
  3. By clicking on the stats button, users can opt for different types of statistics.
  4. If any selected column isn't categorized as "Number," it won't be displayed or included in calculations.
  5. Null or undefined values will be disregarded, ensuring they don't impact the count or any statistics.

ss1:
Screenshot 2024-02-23 at 1 33 09 PM

ss2:
Screenshot 2024-02-23 at 1 33 17 PM

Copy link

parse-github-assistant bot commented Feb 23, 2024

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

Copy link

uffizzi-cloud bot commented Feb 23, 2024

Uffizzi Ephemeral Environment deployment-47177

⌚ Updated Feb 23, 2024, 18:38 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2529

📄 View Application Logs etc.

What is Uffizzi? Learn more

@AshishBarvaliya AshishBarvaliya changed the title Feature: Descriptive statistics for data browser feat: Descriptive statistics for data browser Feb 23, 2024
@mtrezza
Copy link
Member

mtrezza commented Feb 23, 2024

Wow! This is a truly impressive PR!

Could the selected cells have a highlighted cell background color, so that it's easier to identify the selected cells visually? Similar to how you'd see it in a spreadsheet UI.

@AshishBarvaliya
Copy link
Member Author

I've added a lighter shade of blue to ensure that the text and background have sufficient contrast.

Screenshot 2024-02-25 at 6 52 45 PM

Let me know if any alternative styles are needed for the stats menu or if you'd like to add any other types of stats.

@mtrezza mtrezza closed this Feb 26, 2024
@mtrezza mtrezza reopened this Feb 26, 2024
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any selected column isn't categorized as "Number," it won't be displayed or included in calculations.

I found that if there is a string column within the selection, the stats field won't be displayed at all. Is that intended, or should it just be ignored in the calculation? For example, this selection doesn't display anything:

image

I think that actually makes sense, because maybe we cannot always correctly convert a string to a number value. So maybe we should not try to convert it at all and not display anything. Because in the example above there is a number from a number column and a number from a string column. So it could be unclear whether the string number is included or not, if we still displayed the stats field. There are also characters that look like numbers but are not actually different unicodes, so converting some of them and others not may be too confusing. What do you think?

Could you please take another look at the failing jobs?

Copy link

uffizzi-cloud bot commented Feb 26, 2024

Uffizzi Ephemeral Environment deployment-47206

⌚ Updated Feb 26, 2024, 00:44 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2529

📄 View Application Logs etc.

What is Uffizzi? Learn more

@AshishBarvaliya
Copy link
Member Author

I found that if there is a string column within the selection, the stats field won't be displayed at all. Is that intended, or should it just be ignored in the calculation? For example, this selection doesn't display anything:

Yes, this intentional behaviour is designed to prevent confusion. Currently, only 'Number' types are allowed. We can consider adding exceptions for strings if necessary or requested, but for now, it's not required.

I've also addressed the issue with the jobs that were failing.

mtrezza
mtrezza previously approved these changes Feb 26, 2024
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Waiting for tryout in preview env.

Copy link

uffizzi-cloud bot commented Feb 26, 2024

Uffizzi Ephemeral Environment deployment-47272

⌚ Updated Feb 26, 2024, 17:01 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2529

📄 View Application Logs etc.

What is Uffizzi? Learn more

Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
mtrezza
mtrezza previously approved these changes Feb 26, 2024
@mtrezza mtrezza changed the title feat: Descriptive statistics for data browser feat: Descriptive statistics for number cells in data browser Feb 26, 2024
@mtrezza mtrezza changed the title feat: Descriptive statistics for number cells in data browser feat: Add descriptive statistics for number cells in data browser Feb 26, 2024
@mtrezza mtrezza closed this Feb 26, 2024
@mtrezza mtrezza reopened this Feb 26, 2024
Copy link

uffizzi-cloud bot commented Feb 26, 2024

Uffizzi Ephemeral Environment deployment-47274

⌚ Updated Feb 26, 2024, 17:30 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2529

📄 View Application Logs etc.

What is Uffizzi? Learn more

@mtrezza mtrezza merged commit ead9ec4 into parse-community:alpha Feb 26, 2024
10 checks passed
parseplatformorg pushed a commit that referenced this pull request Feb 26, 2024
# [5.4.0-alpha.7](5.4.0-alpha.6...5.4.0-alpha.7) (2024-02-26)

### Features

* Add descriptive statistics for number cells in data browser ([#2529](#2529)) ([ead9ec4](ead9ec4))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0-alpha.7

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Feb 26, 2024
davimacedo pushed a commit to back4app/parse-dashboard that referenced this pull request Apr 4, 2024
* feat: Add refresh indicator to Cloud Config page (parse-community#2505)

* chore(release): 5.3.0-alpha.2 [skip ci]

# [5.3.0-alpha.2](parse-community/parse-dashboard@5.3.0-alpha.1...5.3.0-alpha.2) (2023-10-18)

### Features

* Add refresh indicator to Cloud Config page ([parse-community#2505](parse-community#2505)) ([a10d1f0](parse-community@a10d1f0))

* release

* chore(release): 5.3.0 [skip ci]

# [5.3.0](parse-community/parse-dashboard@5.2.0...5.3.0) (2023-11-16)

### Bug Fixes

* Adding a file when adding a new row in the data browser doesn't show filename ([parse-community#2471](parse-community#2471)) ([5bbb94e](parse-community@5bbb94e))
* File extension is hidden in file field when editing object in modal dialog in data browser ([parse-community#2472](parse-community#2472)) ([8df4e4d](parse-community@8df4e4d))
* Incorrect highlight maker position in class list in data browser ([parse-community#2490](parse-community#2490)) ([8c28d24](parse-community@8c28d24))
* Pasting location coordinates into field of type `GeoPoint` does not work in data browser ([parse-community#2464](parse-community#2464)) ([a8ce343](parse-community@a8ce343))
* Selecting a saved filter in data browser also highlights other filters with equal names ([parse-community#2466](parse-community#2466)) ([35360fe](parse-community@35360fe))
* Vertical scrollbar in data browser is outside visible area when scrolling horizontally ([parse-community#2457](parse-community#2457)) ([5acac3f](parse-community@5acac3f))

### Features

* Add Cloud Function execution on Parse Object in data browser ([parse-community#2409](parse-community#2409)) ([996ce91](parse-community@996ce91))
* Add parameter `selectedField` to script payload to determine which object field was selected when script was invoked ([parse-community#2483](parse-community#2483)) ([e98d653](parse-community@e98d653))
* Add refresh button to Cloud Config page ([parse-community#2480](parse-community#2480)) ([be212b0](parse-community@be212b0))
* Add security checks page ([parse-community#2491](parse-community#2491)) ([103b9c6](parse-community@103b9c6))
* Add support for confirmation dialog before script execution in data browser ([parse-community#2481](parse-community#2481)) ([64d3913](parse-community@64d3913))
* Add typing with auto-complete to select a filter field in the data browser ([parse-community#2463](parse-community#2463)) ([257f76b](parse-community@257f76b))
* Reopen last opened class when navigating to data browser ([parse-community#2468](parse-community#2468)) ([3d7148e](parse-community@3d7148e))

### Reverts

* fix: Vertical scrollbar in data browser is outside visible area when scrolling horizontally ([parse-community#2457](parse-community#2457)) ([parse-community#2477](parse-community#2477)) ([2f1d84e](parse-community@2f1d84e))

* release

* chore(release): 5.4.0-beta.1 [skip ci]

# [5.4.0-beta.1](parse-community/parse-dashboard@5.3.0...5.4.0-beta.1) (2023-11-16)

### Features

* Add refresh indicator to Cloud Config page ([parse-community#2505](parse-community#2505)) ([a10d1f0](parse-community@a10d1f0))

* refactor: Security upgrade js-beautify from 1.14.6 to 1.14.10 (parse-community#2513)

* chore(release): 5.4.0-alpha.1 [skip ci]

# [5.4.0-alpha.1](parse-community/parse-dashboard@5.3.0...5.4.0-alpha.1) (2023-12-02)

### Features

* Add refresh indicator to Cloud Config page ([parse-community#2505](parse-community#2505)) ([a10d1f0](parse-community@a10d1f0))

* feat: Execute script for selected rows (parse-community#2508)

* chore(release): 5.4.0-alpha.2 [skip ci]

# [5.4.0-alpha.2](parse-community/parse-dashboard@5.4.0-alpha.1...5.4.0-alpha.2) (2023-12-16)

### Features

* Execute script for selected rows ([parse-community#2508](parse-community#2508)) ([5d9901e](parse-community@5d9901e))

* fix: Dashboard crashes if Parse Server Cloud Function script returns object (parse-community#2516)

* chore(release): 5.4.0-alpha.3 [skip ci]

# [5.4.0-alpha.3](parse-community/parse-dashboard@5.4.0-alpha.2...5.4.0-alpha.3) (2023-12-16)

### Bug Fixes

* Dashboard crashes if Parse Server Cloud Function script returns object ([parse-community#2516](parse-community#2516)) ([5de08f8](parse-community@5de08f8))

* fix: Data browser redirects to wrong class when changing app (parse-community#2526)

* chore(release): 5.4.0-alpha.4 [skip ci]

# [5.4.0-alpha.4](parse-community/parse-dashboard@5.4.0-alpha.3...5.4.0-alpha.4) (2024-02-15)

### Bug Fixes

* Data browser redirects to wrong class when changing app ([parse-community#2526](parse-community#2526)) ([7713f54](parse-community@7713f54))

* fix: Open pointer in new tab in data browser not working when mount path is not root (parse-community#2527)

* chore(release): 5.4.0-alpha.5 [skip ci]

# [5.4.0-alpha.5](parse-community/parse-dashboard@5.4.0-alpha.4...5.4.0-alpha.5) (2024-02-18)

### Bug Fixes

* Open pointer in new tab in data browser not working when mount path is not root ([parse-community#2527](parse-community#2527)) ([2f4081f](parse-community@2f4081f))

* fix: App metrics for user and installation counts show dash (parse-community#2528)

* chore(release): 5.4.0-alpha.6 [skip ci]

# [5.4.0-alpha.6](parse-community/parse-dashboard@5.4.0-alpha.5...5.4.0-alpha.6) (2024-02-26)

### Bug Fixes

* App metrics for user and installation counts show dash ([parse-community#2528](parse-community#2528)) ([850d7b3](parse-community@850d7b3))

* feat: Add descriptive statistics for number cells in data browser (parse-community#2529)

* chore(release): 5.4.0-alpha.7 [skip ci]

# [5.4.0-alpha.7](parse-community/parse-dashboard@5.4.0-alpha.6...5.4.0-alpha.7) (2024-02-26)

### Features

* Add descriptive statistics for number cells in data browser ([parse-community#2529](parse-community#2529)) ([ead9ec4](parse-community@ead9ec4))

* fix: Config page fails to load (parse-community#2531)

* chore(release): 5.4.0-alpha.8 [skip ci]

# [5.4.0-alpha.8](parse-community/parse-dashboard@5.4.0-alpha.7...5.4.0-alpha.8) (2024-02-29)

### Bug Fixes

* Config page fails to load ([parse-community#2531](parse-community#2531)) ([d721b7c](parse-community@d721b7c))

* feat: Add Node 20 support; remove Node 14, 16 support (parse-community#2532)

* feat: Add Node 20 support; remove Node 14, 16 support (parse-community#2535)

BREAKING CHANGE: Removes support for Node 14 and 16

* chore(release): 6.0.0-alpha.1 [skip ci]

# [6.0.0-alpha.1](parse-community/parse-dashboard@5.4.0-alpha.8...6.0.0-alpha.1) (2024-03-05)

### Features

* Add Node 20 support; remove Node 14, 16 support ([parse-community#2532](parse-community#2532)) ([578a339](parse-community@578a339))
* Add Node 20 support; remove Node 14, 16 support ([parse-community#2535](parse-community#2535)) ([5c90f2d](parse-community@5c90f2d))

### BREAKING CHANGES

* Removes support for Node 14 and 16 ([5c90f2d](5c90f2d))

* refactor: Security upgrade express from 4.18.1 to 4.19.2 (parse-community#2539)

* ci: Fix nginx config for preview environment (parse-community#2542)

* refactor: Upgrade to npm lockfile version 3 (parse-community#2543)

* fix: make cursor pointer for support more icon

* fix: more icon cursor pointer

* fix: remove console from B4aNotification

* feat: add light themed b4aEmptyState

* fix: B4aObjectPicker app crash when class exists not

* fix: cloudcode empty states

* fix: reduce size to remove scrollbar

* fix: remove extra space from REST Console top

* fix: dark themed dropdown arrow

* fix: error modal

* feat: add logRocket

---------

Co-authored-by: patelmilanun <20059797+patelmilanun@users.noreply.github.com>
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: Manuel Trezza <5673677+mtrezza@users.noreply.github.com>
Co-authored-by: Parse Platform <90459499+parseplatformorg@users.noreply.github.com>
Co-authored-by: Ashish Baravaliya <49753983+AshishBarvaliya@users.noreply.github.com>
Co-authored-by: Corey <coreyearleon@icloud.com>
parseplatformorg pushed a commit that referenced this pull request May 16, 2024
# [6.0.0-beta.1](5.4.0...6.0.0-beta.1) (2024-05-16)

### Bug Fixes

* App metrics for user and installation counts show dash ([#2528](#2528)) ([850d7b3](850d7b3))
* Class Level Permissions dialog throws error `TypeError: ce.current is null` for newly created class ([#2549](#2549)) ([27ed692](27ed692))
* Config page fails to load ([#2531](#2531)) ([d721b7c](d721b7c))
* Dashboard crashes if Parse Server Cloud Function script returns object ([#2516](#2516)) ([5de08f8](5de08f8))
* Dashboard scrolls when selecting row in data browser ([#2559](#2559)) ([2aa54a5](2aa54a5))
* Data browser redirects to wrong class when changing app ([#2526](#2526)) ([7713f54](7713f54))
* Deleting all code in the JS Console editor fills in the default code ([#2558](#2558)) ([4b830ba](4b830ba))
* Open pointer in new tab in data browser not working when mount path is not root ([#2527](#2527)) ([2f4081f](2f4081f))

### Features

* Add descriptive statistics for number cells in data browser ([#2529](#2529)) ([ead9ec4](ead9ec4))
* Add filter `starts with` in data browser for fields of type Pointer ([#2553](#2553)) ([0b94ab6](0b94ab6))
* Add Node 20 support; remove Node 14, 16 support ([#2532](#2532)) ([578a339](578a339))
* Add Node 20 support; remove Node 14, 16 support ([#2535](#2535)) ([5c90f2d](5c90f2d))
* Execute script for selected rows ([#2508](#2508)) ([5d9901e](5d9901e))
* Select rows in data browser by clicking and dragging mouse cursor over checkboxes ([#2548](#2548)) ([792ba9e](792ba9e))

### BREAKING CHANGES

* Removes support for Node 14 and 16 ([5c90f2d](5c90f2d))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add descriptive statistics to data browser
3 participants