Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run test suite against ParseStream #509

Merged
merged 3 commits into from
May 12, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented May 11, 2023

New Pull Request Checklist

Issue Description

The test suite runs against cURL, this PR adds stream context tests to the CI. We should support both http clients.

// set curl http client (default if none set)
ParseClient::setHttpClient(new ParseCurlHttpClient());

// set stream http client
// ** requires 'allow_url_fopen' to be enabled in php.ini **
ParseClient::setHttpClient(new ParseStreamHttpClient());

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12 🎉

Comparison is base (d46107e) 98.48% compared to head (5062f70) 98.60%.

❗ Current head 5062f70 differs from pull request most recent head 9853c44. Consider uploading reports for the commit 9853c44 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #509      +/-   ##
============================================
+ Coverage     98.48%   98.60%   +0.12%     
- Complexity     1060     1062       +2     
============================================
  Files            38       38              
  Lines          3225     3229       +4     
============================================
+ Hits           3176     3184       +8     
+ Misses           49       45       -4     
Impacted Files Coverage Δ
src/Parse/HttpClients/ParseStream.php 100.00% <100.00%> (+22.22%) ⬆️
src/Parse/ParseClient.php 95.23% <100.00%> (-0.44%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dplewis dplewis requested a review from mtrezza May 11, 2023 14:03
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit eedefb9 into parse-community:master May 12, 2023
@dplewis dplewis deleted the parse-stream-tests branch May 12, 2023 17:21
@parseplatformorg
Copy link

🎉 This change has been released in version 2.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version Edit label May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version Edit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants