Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Expo push notifications #243

Merged
merged 9 commits into from
May 15, 2024

Conversation

mortenmo
Copy link
Contributor

@mortenmo mortenmo commented May 8, 2024

Expo for React Native is used heavily when creating mobile app. It comes with its own simplified way to create, manage and send push notifications.

https://docs.expo.dev/push-notifications/overview/

With the addition of Installations for Parse JS, it is now easier/possible to use the Parse Server send push notifications using internals

New Pull Request Checklist

Copy link

parse-github-assistant bot commented May 8, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@mortenmo mortenmo changed the title Expo Push Support feat: Expo Push Support May 8, 2024
@mortenmo mortenmo marked this pull request as ready for review May 8, 2024 21:12
package.json Outdated Show resolved Hide resolved
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just add an entry to the README? At least like what was added in #239. If you think that there should be any additional information on how to configure the adapter, feel free to add it.

@mortenmo
Copy link
Contributor Author

mortenmo commented May 9, 2024

Could you just add an entry to the README? At least like what was added in #239. If you think that there should be any additional information on how to configure the adapter, feel free to add it.

Yep, added a little snippet.

@dplewis
Copy link
Member

dplewis commented May 10, 2024

@mortenmo Can you add test cases and ensure code is covered?

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed, could you take a look?

@mtrezza mtrezza changed the title feat: Expo Push Support feat: Add support for Expo push notifications May 10, 2024
@mortenmo
Copy link
Contributor Author

@mtrezza / @dplewis CI failed because I missed the spec/ folder completely (again!!). Added tests for Expo & fixed the current tests failing.

@mtrezza mtrezza mentioned this pull request May 10, 2024
3 tasks
… through PARSE_SERVER_CLEANUP_INVALID_INSTALLATIONS
@mortenmo mortenmo requested a review from mtrezza May 12, 2024 20:00
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; is this ready for merge?

@mtrezza mtrezza merged commit 8987b85 into parse-community:master May 15, 2024
4 checks passed
parseplatformorg pushed a commit that referenced this pull request May 15, 2024
# [6.2.0](6.1.1...6.2.0) (2024-05-15)

### Features

* Add support for Expo push notifications ([#243](#243)) ([8987b85](8987b85))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants