-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add server security check status security.enableCheck
to Features Router
#8679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I will reformat the title to use the proper commit message syntax. |
security.enableCheck
status to FeaturesRoutersecurity.enableCheck
status to FeaturesRouter
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #8679 +/- ##
=======================================
Coverage 94.15% 94.15%
=======================================
Files 186 186
Lines 14688 14688
=======================================
Hits 13830 13830
Misses 858 858 ☔ View full report in Codecov by Sentry. |
mtrezza
reviewed
Jul 3, 2023
mtrezza
requested changes
Mar 23, 2024
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
mtrezza
approved these changes
Mar 23, 2024
security.enableCheck
status to FeaturesRoutersecurity.enableCheck
to FeaturesRouter
security.enableCheck
to FeaturesRoutersecurity.enableCheck
to Features Router
parseplatformorg
pushed a commit
that referenced
this pull request
Mar 24, 2024
# [7.1.0-alpha.2](7.1.0-alpha.1...7.1.0-alpha.2) (2024-03-24) ### Features * Add server security check status `security.enableCheck` to Features Router ([#8679](#8679)) ([b07ec15](b07ec15))
🎉 This change has been released in version 7.1.0-alpha.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Currently, the status of
security.enableCheck
is not passed toFeaturesRouter
Closes: #8678
Approach
Tasks