Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add server security check status security.enableCheck to Features Router #8679

Merged
merged 4 commits into from
Mar 24, 2024

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jun 30, 2023

Pull Request

Issue

Currently, the status of security.enableCheck is not passed to FeaturesRouter

Closes: #8678

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: add security.enableCheck status to FeaturesRouter feat: Add security.enableCheck status to FeaturesRouter Jun 30, 2023
@parse-github-assistant
Copy link

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.15%. Comparing base (79846f7) to head (334075f).

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #8679   +/-   ##
=======================================
  Coverage   94.15%   94.15%           
=======================================
  Files         186      186           
  Lines       14688    14688           
=======================================
  Hits        13830    13830           
  Misses        858      858           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Routers/FeaturesRouter.js Outdated Show resolved Hide resolved
spec/SecurityCheck.spec.js Outdated Show resolved Hide resolved
spec/SecurityCheck.spec.js Outdated Show resolved Hide resolved
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
@mtrezza mtrezza changed the title feat: Add security.enableCheck status to FeaturesRouter feat: Add server security check status security.enableCheck to FeaturesRouter Mar 23, 2024
@mtrezza mtrezza changed the title feat: Add server security check status security.enableCheck to FeaturesRouter feat: Add server security check status security.enableCheck to Features Router Mar 23, 2024
@mtrezza mtrezza merged commit b07ec15 into parse-community:alpha Mar 24, 2024
23 of 26 checks passed
@mtrezza mtrezza deleted the features-router branch March 24, 2024 00:50
parseplatformorg pushed a commit that referenced this pull request Mar 24, 2024
# [7.1.0-alpha.2](7.1.0-alpha.1...7.1.0-alpha.2) (2024-03-24)

### Features

* Add server security check status `security.enableCheck` to Features Router ([#8679](#8679)) ([b07ec15](b07ec15))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow extension of FeaturesRouter
3 participants