Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Required option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations #8915

Merged

Conversation

Moumouls
Copy link
Member

@Moumouls Moumouls commented Feb 7, 2024

Pull Request

Issue

Closes: #8914

Approach

Base all field detection on schema data ,and not on the GQL type ( like the Relation and Pointer type)

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: required field on transform types fix: Required field on transform types Feb 7, 2024
Copy link

Thanks for opening this pull request!

@Moumouls Moumouls changed the title fix: Required field on transform types fix: Required options on special fields (File, GeoPoint, Polygon) on the GQL API mutations Feb 7, 2024
@Moumouls Moumouls changed the title fix: Required options on special fields (File, GeoPoint, Polygon) on the GQL API mutations fix: Required option on special fields (File, GeoPoint, Polygon) on the GQL API mutations Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.16%. Comparing base (6fb19bd) to head (2b4fe38).

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8915      +/-   ##
==========================================
+ Coverage   94.14%   94.16%   +0.02%     
==========================================
  Files         186      186              
  Lines       14679    14679              
==========================================
+ Hits        13820    13823       +3     
+ Misses        859      856       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Moumouls Moumouls requested a review from mtrezza February 7, 2024 19:05
@mtrezza
Copy link
Member

mtrezza commented Feb 10, 2024

Is this a breaking change?

@mtrezza
Copy link
Member

mtrezza commented Feb 15, 2024

@Moumouls Could you please resolve the conflicts, and clarify whether this is a breaking change intended for Parse Server 7? In a few days we'll release Parse Server 7, so if this is a breaking change, merging it before release would be easier.

…load

# Conflicts:
#	spec/ParseGraphQLServer.spec.js
#	src/GraphQL/transformers/mutation.js
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires lint fixes; it seems that the local lint adds spaces in curly braces and changes indentation.

@mtrezza mtrezza changed the title fix: Required option on special fields (File, GeoPoint, Polygon) on the GQL API mutations fix: Required option not handled correctly on special fields (File, GeoPoint, Polygon) on the GQL API mutations Mar 20, 2024
@mtrezza mtrezza changed the title fix: Required option not handled correctly on special fields (File, GeoPoint, Polygon) on the GQL API mutations fix: Required option not handled correctly for special fields (File, GeoPoint, Polygon) on the GQL API mutations Mar 20, 2024
@mtrezza mtrezza changed the title fix: Required option not handled correctly for special fields (File, GeoPoint, Polygon) on the GQL API mutations fix: Required option not handled correctly for special fields (File, GeoPoint, Polygon) on the GQL API mutations Mar 20, 2024
@mtrezza mtrezza changed the title fix: Required option not handled correctly for special fields (File, GeoPoint, Polygon) on the GQL API mutations fix: Required option not handled correctly for special fields (File, GeoPoint, Polygon) on GQL API mutations Mar 20, 2024
@mtrezza mtrezza changed the title fix: Required option not handled correctly for special fields (File, GeoPoint, Polygon) on GQL API mutations fix: Required option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations Mar 20, 2024
@mtrezza mtrezza merged commit 907ad42 into parse-community:alpha Mar 20, 2024
24 of 26 checks passed
parseplatformorg pushed a commit that referenced this pull request Mar 20, 2024
# [7.0.0-alpha.30](7.0.0-alpha.29...7.0.0-alpha.30) (2024-03-20)

### Bug Fixes

* `Required` option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations ([#8915](#8915)) ([907ad42](907ad42))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.0.0-alpha.30

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Mar 20, 2024
parseplatformorg pushed a commit that referenced this pull request Mar 23, 2024
# [7.1.0-alpha.1](7.0.0...7.1.0-alpha.1) (2024-03-23)

### Bug Fixes

* `Required` option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations ([#8915](#8915)) ([907ad42](907ad42))

### Features

* Add `silent` log level for Cloud Code ([#8803](#8803)) ([5f81efb](5f81efb))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-alpha.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

required field on Parse Schema is not handled correctly on special types on the GQL API
3 participants