Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integration] Create stream does not work with s3 object lock enabled. #215

Closed
AhmedmmAli opened this issue Dec 14, 2022 · 4 comments · Fixed by #218
Closed

[Integration] Create stream does not work with s3 object lock enabled. #215

AhmedmmAli opened this issue Dec 14, 2022 · 4 comments · Fixed by #218
Assignees
@trueleo

Comments

@AhmedmmAli
Copy link

AhmedmmAli commented Dec 14, 2022 •
edited

  • Based on AWS putObject on S3 documentation, We must pass content-MD5 option to upload objects to S3 with object lock enabled.
  • create stream function does not send the content-MD5 option within the API request sent to AWS Code.
@nitisht
Copy link
Member

nitisht commented Dec 14, 2022

Thanks @AhmedmmAli we'll take a look shortly

@trueleo
Copy link
Contributor

trueleo commented Dec 16, 2022 •
edited

@AhmedmmAli I have looked into it. Adding header is an easy change but it might break application if the some S3 policy disallows overwriting file. Parseable stores metadata and alert configuration files on the s3 which might often be updated.

But anyways we will try to add this option soon

@trueleo trueleo mentioned this issue Dec 17, 2022
Merged
3 tasks
@nitisht
Copy link
Member

nitisht commented Dec 17, 2022

@AhmedmmAli would it be possible for you to test the PR #218 . We can help you with a build or docker image if needed.

@nitisht
Copy link
Member

nitisht commented Dec 20, 2022

Merging the PR #218 - it is working in our tests. Feel free to reopen if it still doesn't work for you @AhmedmmAli

nitisht pushed a commit that referenced this issue Dec 20, 2022
@trueleo
Add option to set content md5 header (#218)
780e141 
This PR adds option in S3 configuration to enable 
content md5 header.

This option can be enabled by setting P_S3_SET_CONTENT_MD5 
environment variable to true. When the option is 
set to true, application server will calculate and set 
content md5 header in AWS S3 client.

Fixes #215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trueleo trueleo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to set content md5 header trueleo/parseable
3 participants
@nitisht @AhmedmmAli @trueleo