Update gh workflows for multi arch build #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163
Description
Add support to build images for linux/arm64, linux/amd64
Update to the
-
.github/workflows/build-push-edge-debug.yaml-
.github/workflows/build-push-edge.yamlworkflow to build multi-arch images for the edge-debug and edge tags respectively.
From the Docker documentation:
QEMU and Docker Buildx needed to be setup in the workflow to build multi-arch images.
The documentation suggests using the
docker/build-push-action@v5action to build multi-arch images. So I updated the same.This PR has:
added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
Is able to build multi-arch images for the edge-debug and edge tags respectively, tested manually