Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node_url field to Cli struct and update related code #734

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

Eshanatnight
Copy link
Contributor

No description provided.

Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validated the changes, looks good to merge

@nikhilsinhaparseable nikhilsinhaparseable merged commit 7bbb584 into parseablehq:main Apr 3, 2024
6 checks passed
@Eshanatnight Eshanatnight deleted the ip-env-update branch April 3, 2024 10:54
nikhilsinhaparseable added a commit to nikhilsinhaparseable/parseable that referenced this pull request Apr 20, 2024
…#734)

* Add node_url field to Cli struct and update related code

* Update required flag for Node URL in CLI

* updated logic to have server address (ip:port) in parquet file name similar to other json files

---------

Co-authored-by: Nikhil Sinha <nikhil.sinha@cloudsurfex.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants