Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Geolocation: Select closest stop based on GPS #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

odbol
Copy link

@odbol odbol commented May 27, 2016

Love your app! The one thing I was missing was one that could select the stop closest to me automatically.

Let me know what you think.

@odbol
Copy link
Author

odbol commented May 28, 2016

hmmm... I have no idea what that test is or why it's failing. What is percy?

@odbol
Copy link
Author

odbol commented May 28, 2016

So, it looks like Chrome will block the GPS if it's served from a insecure non-HTTPS protocol. :(

@parshap
Copy link
Owner

parshap commented Aug 31, 2016

This is a great -- thanks @odbol! Don't worry about the test failure, it's a configuration issue with Travis, PR builds won't have authentication to trigger a Percy build (visual testing -- see percio.io).

I'll see if I can get https up and running -- I've been wanting to do it anyway.

I'm also pondering the experience of having the "From" field geolocate automatically. I'm thinking about having a geolocate button next to each location input.

@parshap
Copy link
Owner

parshap commented Aug 31, 2016

PS: I'm curious how you came across nextcaltrain.com?

@odbol
Copy link
Author

odbol commented Aug 31, 2016

Awesome! I think I was just searching for a list of Caltrain schedules (basically I had the exact same desire for a simple app that could show me the schedules easily... all the others out there were way too complicated or didn't work right.) Yours fit the bill perfectly and saved me from writing a lot of code. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants