Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"*" as a selector #4

Closed
mightyiam opened this issue Sep 22, 2014 · 3 comments
Closed

"*" as a selector #4

mightyiam opened this issue Sep 22, 2014 · 3 comments

Comments

@mightyiam
Copy link

"*" as a selector seems to fail at

  node.children = vtree.children.map(function(child) {

Looking for .children on a text node.

Did you ever try "*"?

@mightyiam
Copy link
Author

Excuse me. Invalid vtree provided.

@mightyiam
Copy link
Author

This occurred because the provided vtree was a clone, produced by lodash.clone(vtree, true).

This is probably because your implementation expects some inherited properties, which are not cloned by lodash.clone.

I guess that your implementation follows the specs...

@mightyiam
Copy link
Author

Ahuh. See Matt-Esch/virtual-dom#101 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant