SIRE-9538 MongoDB 6 support using mongosh instead of old mongo client

Reviewed-by: muspelkat

lib/puppet/provider/mongodb.rb

@@ -104,7 +104,6 @@ def self.mongo_cmd(db, host, cmd)
     end
 
     args += ['--eval', "\"#{cmd}\""]
-    Puppet.warning "mongosh: #{args}"
     mongo(args)
   end
 
@@ -157,9 +156,9 @@ def self.auth_enabled(config = nil)
   end
 
   # Mongo Command Wrapper
-  def self.mongo_eval(cmd, db = 'admin', retries = 2, host = nil)
+  def self.mongo_eval(cmd, db = 'admin', retries = 10, host = nil)
     retry_count = retries
-    retry_sleep = 1
+    retry_sleep = 3
     cmd = mongorc_file + cmd if mongorc_file
 
     out = nil
@@ -179,14 +178,12 @@ def self.mongo_eval(cmd, db = 'admin', retries = 2, host = nil)
       end
     end
 
-
     raise Puppet::ExecutionFailure, "Could not evaluate MongoDB shell command: #{cmd}" unless out
 
-    # Puppet::Util::MongodbOutput.sanitize(out)
     out
   end
 
-  def mongo_eval(cmd, db = 'admin', retries = 2, host = nil)
+  def mongo_eval(cmd, db = 'admin', retries = 10, host = nil)
     self.class.mongo_eval(cmd, db, retries, host)
   end
 

lib/puppet/provider/mongodb_database/mongodb.rb

@@ -9,22 +9,7 @@
   def self.instances
     require 'json'
 
-    # pre_cmd = '
-    # try {
-    #   version=parseInt(db.version().split(\'.\')[0])
-    #   if (version>=5){
-    #     db.getMongo().setReadPref(\'nearest\')
-    #   }
-    #   else{
-    #     rs.secondaryOk()
-    #   }
-    # }
-    # catch (err) {
-    #   rs.slaveOk()
-    # }
-    # '.squeeze(' ')
     mongo_eval_result = mongo_eval("JSON.stringify(db.getMongo().getDBs())")
-    Puppet.warning "#### DBS  #{mongo_eval_result} ####"
 
     dbs = JSON.parse mongo_eval_result
 
@@ -45,7 +30,7 @@ def self.prefetch(resources)
 
   def create
     if db_ismaster
-      out = mongo_eval('db.dummyData.insert({"created_by_puppet": 1})', @resource[:name])
+      out = mongo_eval('db.dummyData.insertOne({"created_by_puppet": 1})', @resource[:name])
       raise "Failed to create DB '#{@resource[:name]}'\n#{out}" if %r{writeError} =~ out
     else
       Puppet.warning 'Database creation is available only from master host'

lib/puppet/provider/mongodb_replset/mongo.rb

@@ -156,7 +156,7 @@ def get_hosts_status(members)
       status = rs_status(host)
       raise Puppet::Error, "Can't configure replicaset #{name}, host #{host} is not supposed to be part of a replicaset." if status.key?('errmsg') && status['errmsg'] == 'not running with --replSet'
 
-      if auth_enabled && status.key?('errmsg') && (status['errmsg'].include?('unauthorized') || status['errmsg'].include?('not authorized') || status['errmsg'].include?('requires authentication')) || status.include?('command replSetGetStatus requires authentication')
+      if auth_enabled && status.key?('errmsg') && (status['errmsg'].include?('unauthorized') || status['errmsg'].include?('not authorized') || status['errmsg'].include?('requires authentication'))
         Puppet.warning "Host #{host} is available, but you are unauthorized because of authentication is enabled: #{auth_enabled}"
         alive.push(member)
       end

manifests/server.pp

@@ -127,12 +127,13 @@
     $admin_password
   }
   if $create_admin and ($service_ensure == 'running' or $service_ensure == true) {
-    mongodb::db { 'admin':
-      user            => $admin_username,
-      auth_mechanism  => $admin_auth_mechanism,
-      password        => $admin_password_unsensitive,
-      roles           => $admin_roles,
-      update_password => $admin_update_password,
+    mongodb_user { "admin user":
+      ensure         => present,
+      username       => $admin_username,
+      database       => 'admin',
+      roles          => $admin_roles,
+      auth_mechanism => $auth_mechanism,
+      password       => $admin_password,
     }
 
     # Make sure it runs before other DB creation
@@ -170,7 +171,7 @@
 
       # Make sure that the ordering is correct
       if $create_admin {
-        Class['mongodb::replset'] -> Mongodb::Db['admin']
+        Class['mongodb::replset'] -> Mongodb_user['admin user']
       }
     }
   }

manifests/server/config.pp

@@ -175,10 +175,10 @@
     $admin_password
   }
   if $handle_creds {
-    if versioncmp($version, '6.0') >= 0 {
-      $major_version_greater6 = true
+    if versioncmp($version, '5.0') >= 0 {
+      $major_version_greater5 = true
     } else {
-      $major_version_greater6 = false
+      $major_version_greater5 = false
     }
     file { $rcfile:
       ensure  => file,

manifests/server/install.pp

@@ -36,7 +36,7 @@
   }
   unless defined(Package[$mongosh_package_name]) {
     package { 'mongodb_mongosh':
-      ensure => latest,
+      ensure => present,
       name   => $mongosh_package_name,
       tag    => 'mongodb_mongosh_package',
     }

templates/mongoshrc.js.erb

@@ -30,7 +30,7 @@ if (authRequired()) {
   <%- if @replset -%>
   // rs.slaveOk + rs secondaryOk have been deprecated, use setReadPref when running mongodb version >=5
     try {
-  <%- if @major_version_greater6 -%>
+  <%- if @major_version_greater5 -%>
         db.getMongo().setReadPref('nearest')
   <%- else -%>
         rs.secondaryOk()
@@ -56,10 +56,8 @@ if (authRequired()) {
       }
   <%- else -%>
     try {
-      var prev_db = db
-      db = db.getSiblingDB('admin')
-      db.auth('<%= @admin_username %>', '<%= @admin_password_unsensitive %>')
-      db = db.getSiblingDB(prev_db)
+      admin = db.getSiblingDB('admin')
+      admin.auth('<%= @admin_username %>', '<%= @admin_password_unsensitive %>')
     }
     catch (err) {
       // This isn't catching authentication errors as I'd expect...