#237: Handled reviews comments from @mvanaken.

parsingdata · May 23, 2018 · 7880b56 · 7880b56
1 parent dba4d5a
commit 7880b56
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/pom.xml b/pom.xml
@@ -67,6 +67,9 @@
     <source-plugin.version>3.0.1</source-plugin.version>
     <pitest-maven.version>1.2.4</pitest-maven.version>
     <maven-jar-plugin.version>3.0.2</maven-jar-plugin.version>
+    <errorprone.maven.compiler.version>3.3</errorprone.maven.compiler.version>
+    <errorprone.plexus.javac.version>2.8.3</errorprone.plexus.javac.version>
+    <errorprone.core.version>2.3.1</errorprone.core.version>
   </properties>
 
   <profiles>
@@ -101,28 +104,24 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-compiler-plugin</artifactId>
-        <version>3.3</version>
+        <version>${errorprone.maven.compiler.version}</version>
         <configuration>
           <compilerId>javac-with-errorprone</compilerId>
           <forceJavacCompilerUse>true</forceJavacCompilerUse>
-          <!-- maven-compiler-plugin defaults to targeting Java 5, but our
-               javac only supports >=6 -->
-          <source>8</source>
-          <target>8</target>
           <showWarnings>true</showWarnings>
         </configuration>
         <dependencies>
           <dependency>
             <groupId>org.codehaus.plexus</groupId>
             <artifactId>plexus-compiler-javac-errorprone</artifactId>
-            <version>2.8.3</version>
+            <version>${errorprone.plexus.javac.version}</version>
           </dependency>
           <!-- override plexus-compiler-javac-errorprone's dependency on
                Error Prone with the latest version -->
           <dependency>
             <groupId>com.google.errorprone</groupId>
             <artifactId>error_prone_core</artifactId>
-            <version>2.3.1</version>
+            <version>${errorprone.core.version}</version>
           </dependency>
         </dependencies>
       </plugin>