Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let StructSinks be attached dynamically #12

Closed
jvdb opened this issue Mar 31, 2016 · 0 comments
Closed

Let StructSinks be attached dynamically #12

jvdb opened this issue Mar 31, 2016 · 0 comments
Labels
enhancement major
Milestone
5.0.0

Comments

@jvdb
Copy link
Contributor

jvdb commented Mar 31, 2016

Right now a callback can be assigned to a token by wrapping it in a Str. Instead of this static mapping, a more dynamic approach is more useful, which will allow dynamically turning callbacks on and off and allow adding callbacks to any token at any time.

Together with #11 this will make Str obsolete.
@jvdb jvdb mentioned this issue Mar 31, 2016
Closed
jvdb added a commit that referenced this issue Sep 7, 2016
@jvdb
#12: Generic callbacks. Refactored some logic into Environment.
504e12e
jvdb added a commit that referenced this issue Sep 7, 2016
@jvdb
#12: Refactoring. Added license headers.
b369cf7
jvdb added a commit that referenced this issue Sep 7, 2016
@jvdb
#12: Simplified callback interface and implementation.
63fe8b1
@jvdb jvdb modified the milestone: 5.0.0 Sep 8, 2016
@jvdb jvdb mentioned this issue Sep 8, 2016
Closed
jvdb added a commit that referenced this issue Sep 14, 2016
@jvdb
#12: Add BaseCallback and test.
2b84a57
jvdb added a commit that referenced this issue Sep 14, 2016
@jvdb
#12: Deprecated StructSink and associated Shorthand methods.
e49fafe
This was referenced Sep 14, 2016
Closed
Merged
jvdb added a commit that referenced this issue Sep 15, 2016
@jvdb
#12: Removed unused code from TokenCallbackList.
68b943b
jvdb added a commit that referenced this issue Sep 15, 2016
@jvdb
#12: Added test code for toString() on Environment with Callback(s). …
d5c24c1 
…Fixed Def's toString(). Removed obsolete code from TokenCallbackList.
jvdb added a commit that referenced this issue Sep 16, 2016
@jvdb
#12: Removed some duplication from Environment constructors and remov…
71b9c3c 
…ed an unused one. Reverted BaseCallback to abstract class.
jvdb added a commit that referenced this issue Sep 16, 2016
@jvdb
#12: Fixed method and import.
8618a6a
jvdb added a commit that referenced this issue Sep 16, 2016
@jvdb
#12: Moved handling of callbacks to Token base class, which hides it …
a0c8655 
…from the public API.
@jvdb jvdb closed this as completed in #89 Sep 16, 2016
@rdvdijk rdvdijk mentioned this issue Oct 11, 2016
Merged
@jvdb jvdb added the major label Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement major
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@jvdb