Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow access to current value of iterator #236

Closed
jvdb opened this issue Apr 11, 2018 · 0 comments
Closed

Allow access to current value of iterator #236

jvdb opened this issue Apr 11, 2018 · 0 comments
Assignees
@jvdb @mvanaken
Labels
enhancement major
Milestone
8.0.0

Comments

@jvdb
Copy link
Contributor

jvdb commented Apr 11, 2018 •
edited
Loading

With tokens such as Rep and RepN, it is often useful to be able to access the value of N, which refers to the current iteration count of the loop.

  1. Should this the 0 or 1-based? -> 0-based seems logical, given that other ValueExpressions use it too.
  2. What about nested loops? Default would seem to always refer to the (current) deepest loop, but are there use cases that require access to multiple levels? -> Implement simplest support first, which is only returning the index of the deepest (= current) level.
@jvdb jvdb added this to the 7.2.0 milestone Jun 30, 2018
@jvdb jvdb self-assigned this Jun 30, 2018
jvdb added a commit that referenced this issue Jul 2, 2018
@jvdb
#236: Basic, compiling and failing tests for the CurrentIndex ValueEx…
e725c68 
…pression.
jvdb added a commit that referenced this issue Jul 3, 2018
@jvdb
#236: Added test for another Token that needs to be included: While.
e6b2f37
jvdb added a commit that referenced this issue Jul 4, 2018
@jvdb
#236: Basic implementation and tests.
0e12551
jvdb added a commit that referenced this issue Jul 4, 2018
@jvdb
#236: Added (failing) test for using CurrentIndex in a nested iterable.
dac4afb
mvanaken added a commit that referenced this issue Jul 17, 2018
@mvanaken
#236: Improved currentIndex implementation by looking for the deepest…
b449cff 
… iterable and counting siblings a long the way.
jvdb added a commit that referenced this issue Jul 18, 2018
@jvdb
#236: Renamed CurrentIndex to CurrentIteration to better reflect what…
a294916 
… it represents. Cleaned up test a bit.
jvdb added a commit that referenced this issue Jul 18, 2018
@jvdb
#236: Fixed one of the CurrentIteration tests.
ec291c2
jvdb added a commit that referenced this issue Jul 18, 2018
@jvdb
#236: Simplified implementation of CurrentIteration, which also impro…
c3c961e 
…ves coverage.
jvdb added a commit that referenced this issue Jul 18, 2018
@jvdb
#236: Improved test coverage for CurrentIteration.
cab9c3e
jvdb added a commit that referenced this issue Jul 18, 2018
@jvdb
#236: Converted CurrentIteration to use trampolines for recursion.
3450821
jvdb added a commit that referenced this issue Jul 18, 2018
@jvdb
#236: Added unit test for CurrentIteration.
0d2401b
mvanaken added a commit that referenced this issue Jul 20, 2018
@mvanaken
#236: Keep track of the last iterable instead of the last iteration a…
ad98634 
…nd count the iterations of the iterable afterwards.
jvdb added a commit that referenced this issue Jul 21, 2018
@jvdb
#236: Small refactorings.
f8f5034
mvanaken added a commit that referenced this issue Jul 24, 2018
@mvanaken
#236: Make CurrentIteration return empty value when referencing outsi…
a17967c 
…de an iterable scope.
jvdb added a commit that referenced this issue Jul 31, 2018
@jvdb
#236: More tests. Unfortunately, no way to more precisely check for e…
b2961aa 
…mpty.
@mvanaken mvanaken mentioned this issue Jul 31, 2018
Closed
mvanaken added a commit that referenced this issue Aug 20, 2018
@mvanaken
#236: New implementation for current iteration, which is now tracked …
6fa43c5 
…within ParseState, instead of extracting it out of the ParseGraph. The iteration is now independent on the parse result.
mvanaken added a commit that referenced this issue Aug 20, 2018
@mvanaken
#236: Removed redundant import.
ebfcf71
mvanaken added a commit that referenced this issue Aug 24, 2018
@mvanaken
#236: Processed review comments of @rdvdijk.
6b72849
mvanaken added a commit that referenced this issue Aug 24, 2018
@mvanaken
#236: Included ToString test for ParseState with iterations.
fe71ac2
mvanaken added a commit that referenced this issue Sep 3, 2018
@mvanaken
#236: Processed review comments from @rdvdijk @ccreeten.
8f9d2c3
jvdb added a commit that referenced this issue Sep 3, 2018
@jvdb
#236: Fixed a failing test.
97a66c5
jvdb added a commit that referenced this issue Sep 10, 2018
@jvdb
#236: Added test to repair test coverage.
5442e7a
jvdb added a commit that referenced this issue Sep 16, 2018
@jvdb
#236: Replaced null-check with isEmpty()-call, added newline, improve…
c63f84c 
…d javadoc. Based on review comments from @rdvdijk and @ccreeten.
jvdb added a commit that referenced this issue Sep 16, 2018
@jvdb
#236: Removed dependency on the javafx Pair class by adding trivial I…
840c354 
…mmutablePair class.
@jvdb jvdb closed this as completed in 762b9f1 Sep 17, 2018
@jvdb jvdb added the major label Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvdb jvdb

@mvanaken mvanaken

Labels
enhancement major
Milestone
8.0.0
Development

No branches or pull requests
2 participants
@jvdb @mvanaken