Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UnliftIO variant #6

Merged
merged 6 commits into from Mar 10, 2022
Merged

Add UnliftIO variant #6

merged 6 commits into from Mar 10, 2022

Conversation

parsonsmatt
Copy link
Owner

@parsonsmatt parsonsmatt commented Mar 10, 2022 •
edited

This PR adds a variant of the API that uses MonadUnliftIO instead of MonadCatch and MonadThrow. Mostly because that's how we roll at work.

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR.
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts).

parsonsmatt
parsonsmatt commented Mar 10, 2022
View reviewed changes
src/Control/Exception/Annotated.hs
@@ -37,6 +37,7 @@ module Control.Exception.Annotated
, checkpointCallStackWith
-- * Handling Exceptions
, catch
, catches
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao

src/Control/Exception/Annotated.hs
@@ -183,7 +184,7 @@ catch action handler =
-- | Like 'Safe.catches', but this function enhance the provided 'Handler's
-- to "see through" any 'AnnotatedException's.
--
-- @since 0.1.1.0
-- @since 0.1.2.0
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s i g h

src/Control/Exception/Annotated/UnliftIO.hs
Comment on lines +86 to +87
withRunInIO $ \runInIO ->
liftIO $ Catch.checkpointMany anns (runInIO action)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b o r i n g

@parsonsmatt parsonsmatt merged commit 4df4fe6 into master Mar 10, 2022
@parsonsmatt parsonsmatt deleted the matt/add-unliftio-variant branch March 10, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@parsonsmatt