Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Booleans should be atoms, not strings #33

Merged
merged 1 commit into from Dec 6, 2016
Merged

Bugfix: Booleans should be atoms, not strings #33

merged 1 commit into from Dec 6, 2016

Conversation

ThomasWeiser
Copy link
Contributor

A JSON boolean looks like this, i.e. without quotes around true:

{ "supported-by-me": true }

Accordingly Elixir code should use the builtin atoms true and false instead of strings like "true". These atoms result in valid JSON code.

@ThomasWeiser
Booleans should be atoms, not strings
b749840 
in Elixir code as well as in JSON
@ThomasWeiser ThomasWeiser mentioned this pull request Dec 5, 2016
Merged
1 task
@oliverbarnes oliverbarnes merged commit c9ead57 into master Dec 6, 2016
@oliverbarnes oliverbarnes deleted the 33-fix-booleans branch December 6, 2016 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverbarnes oliverbarnes oliverbarnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThomasWeiser @oliverbarnes