Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://github.com/participedia/api/issues/809 #818

Merged
merged 6 commits into from Jan 6, 2020
Merged

https://github.com/participedia/api/issues/809 #818

merged 6 commits into from Jan 6, 2020

Conversation

@paninee
Copy link
Contributor

paninee commented Jan 4, 2020

@ascott

Merged 3 PR of these changes

#773
#774
#775

vitaly-t and others added 6 commits Oct 18, 2019
There is no point executing queries as a batch when you do not use the result of the batch, and only want to execute the queries.

The same applies to a few of your other files here...
Throwing away more useless batch uses.
More useless batch uses.
@paninee paninee changed the title Pan 809 https://github.com/participedia/api/issues/809 Jan 4, 2020
@paninee paninee requested a review from ascott Jan 4, 2020
@ascott

This comment has been minimized.

Copy link
Contributor

ascott commented Jan 4, 2020

@paninee this looks good to me. thank you! let's ship to staging and test there.

@ascott
ascott approved these changes Jan 4, 2020
@paninee paninee merged commit 6aaf769 into master Jan 6, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.