Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix image rendering bug on home/search and reader pages #848

Merged
merged 3 commits into from Feb 4, 2020
Merged

fix image rendering bug on home/search and reader pages #848

merged 3 commits into from Feb 4, 2020

Conversation

ascott
Copy link
Contributor

@ascott ascott commented Feb 4, 2020 •
edited

Description

  • use encodeURI to fix urls with spaces in them

Context/Issue Link

How has this been tested? How can it be tested?

  • copied an offending image url to my localdb to verify the issue and test the fix
  • tested locally on the home/search page and on entry reader pages

@ascott ascott requested a review from paninee February 4, 2020 00:45
@ascott ascott merged commit 5b3437e into master Feb 4, 2020
@ascott
Copy link
Contributor Author

ascott commented Feb 4, 2020

this fixed some of the issues, but not all of the issues.

@paninee paninee deleted the alanna-fix-image-rendering-bug branch April 7, 2021 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paninee paninee Awaiting requested review from paninee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ascott