Debug window console #470

vikas-cis-zz · 2017-12-06T16:28:53Z

coveralls · 2017-12-06T16:35:18Z

Coverage decreased (-0.04%) to 48.273% when pulling 3132e5a on vikas-cis:debug_window_console into 071ec6c on particl:restructure.

coveralls · 2017-12-07T09:26:30Z

Coverage decreased (-0.04%) to 48.273% when pulling 343c599 on vikas-cis:debug_window_console into 071ec6c on particl:restructure.

coveralls · 2017-12-07T15:59:59Z

Coverage increased (+0.0005%) to 48.311% when pulling 97f604e on vikas-cis:debug_window_console into 071ec6c on particl:restructure.

kewde · 2017-12-12T00:12:28Z

src/app/wallet/settings/modal/help-modal/console-modal.component.ts

+    this.currentTime = this.dateFormatter(new Date());
+  }
+
+  private dateFormatter(d: Date) {


Please move this to utils?

I found a similar one here:
https://github.com/particl/partgui/blob/f4ad94c68e3ec85b6093c72cb96eed06f0f04882/src/app/wallet/shared/transaction.model.ts#L91-L100

Let's have one shared dateformat for the whole gui

kewde · 2017-12-12T00:16:21Z

src/app/wallet/wallet.module.ts

@@ -25,7 +26,8 @@ import { routing } from './wallet.routing';
    OverviewComponent,
    SettingsComponent,
    StakinginfoComponent,
-    ColdstakeComponent
+    ColdstakeComponent,
+    ConsoleModalComponent


Just make the console, it's own module from Core-UI. You should be able to just use it, without having to import it I believe.

kewde · 2017-12-12T00:16:42Z

src/app/wallet/settings/modal/help-modal/console-modal.component.html

@@ -0,0 +1,55 @@
+<div class="containerX">


Yeah, We have decided to have the same inside setting for future perspective as in future this will moves back to setting page.

kewde

Duplication of code

coveralls · 2017-12-12T13:06:24Z

Coverage increased (+0.2%) to 48.481% when pulling 4c34903 on vikas-cis:debug_window_console into 071ec6c on particl:restructure.

coveralls · 2017-12-16T14:33:36Z

Coverage increased (+0.2%) to 47.951% when pulling 73a6e22 on vikas-cis:debug_window_console into a0801cd on particl:dev.

anandsinghparihar · 2017-12-19T13:21:42Z

Hey @vikas-cis Could please do following things first:

Add Icons
Design changes req.
Add tool tip or placeholder for basic command hint.
After entering the command 'add auto scroll down'.

vikas-cis-zz · 2017-12-19T13:28:36Z

@gerlofvanek Can you please provide icon as suggested by @anandsinghparihar

coveralls · 2018-01-03T14:38:20Z

Coverage increased (+0.2%) to 47.223% when pulling 79fef25 on vikas-cis:debug_window_console into 5daea31 on particl:dev.

…bug_window_console

coveralls · 2018-01-03T17:46:26Z

Coverage increased (+0.2%) to 47.223% when pulling bd53cbd on vikas-cis:debug_window_console into 5daea31 on particl:dev.

vikas-cis-zz · 2018-01-04T12:12:15Z

@AllienWorks it looks great just wondering about clear text (cross icon) which I have added for clearing the text, we don't need that ?

coveralls · 2018-01-04T12:14:06Z

Coverage increased (+0.2%) to 47.223% when pulling 8d7152f on vikas-cis:debug_window_console into 5daea31 on particl:dev.

coveralls · 2018-01-04T14:33:37Z

Coverage increased (+0.2%) to 47.223% when pulling f48ecbf on vikas-cis:debug_window_console into 5daea31 on particl:dev.

AllienWorks · 2018-01-04T14:37:40Z

Layout & design tweaked.

@vikas-cis I've removed the icon, it's not needed at all.

Modal's close button still needs implementation – can somebody do that? (I've tried to copy it from QR modal, but it's not working..)

changes made

AllienWorks · 2018-01-04T16:54:28Z

Preview:

pciavald · 2018-01-04T18:52:15Z

src/app/core-ui/main/status/modal/help-modal/console-modal.component.html

+<div class="console-modal">
+  <!-- FIXME: make the close button work -->
+  <button class="small-close_button">
+    <mat-icon fontSet="partIcon" fontIcon="part-circle-remove"></mat-icon>


this needs to be implemented

coveralls · 2018-01-04T18:58:13Z

Coverage increased (+0.2%) to 47.257% when pulling 2eeb9a4 on vikas-cis:debug_window_console into 5daea31 on particl:dev.

coveralls · 2018-01-05T09:14:25Z

Coverage increased (+0.05%) to 47.061% when pulling 389cf17 on vikas-cis:debug_window_console into 5daea31 on particl:dev.

coveralls · 2018-01-05T11:58:43Z

Coverage increased (+0.05%) to 47.061% when pulling 38206ba on vikas-cis:debug_window_console into 5daea31 on particl:dev.

debug-window implementation similar like QT wallet

a4307e7

vikas-cis-zz changed the base branch from master to restructure December 6, 2017 16:29

vikas-cis-zz self-assigned this Dec 6, 2017

vikas-cis-zz requested review from gerlofvanek, AllienWorks, rynomster and kewde December 6, 2017 16:31

vikas-cis-zz assigned vikas-cis-zz and unassigned vikas-cis-zz Dec 6, 2017

vikas-cis-zz added the ready for review label Dec 6, 2017

merge changes with restructure

343c599

vikas-cis-zz force-pushed the debug_window_console branch from 3132e5a to 343c599 Compare December 7, 2017 09:19

Move help-modal to status and done changes accordingly

97f604e

kewde reviewed Dec 12, 2017

View reviewed changes

kewde previously requested changes Dec 12, 2017

View reviewed changes

delete the duplicate folder and moved dateformatter to util

4c34903

vikas-cis-zz removed the request for review from rynomster December 12, 2017 13:43

vikas-cis-zz changed the base branch from restructure to dev December 12, 2017 13:50

resolve conflictions

73a6e22

vikas-cis-zz requested a review from anandsinghparihar December 19, 2017 11:41

AllienWorks removed their request for review December 19, 2017 13:33

vikas-cis-zz force-pushed the debug_window_console branch from 09d6551 to 79fef25 Compare January 3, 2018 14:32

Martin Allien added 2 commits January 3, 2018 18:36

Console modal layout basics

a94740b

Merge remote-tracking branch 'vikas-cis/debug_window_console' into de…

bd53cbd

…bug_window_console

pciavald mentioned this pull request Jan 4, 2018

History Tab labels to be in past tense #583

Closed

lint fix

8d7152f

AllienWorks added this to the 1.2 milestone Jan 4, 2018

Console final layout tweaks

f48ecbf

style

2eeb9a4

gerlofvanek approved these changes Jan 4, 2018

View reviewed changes

pciavald self-requested a review January 4, 2018 18:51

pciavald suggested changes Jan 4, 2018

View reviewed changes

pciavald modified the milestones: 1.2, 1.1 Jan 4, 2018

vikas-cis added 2 commits January 5, 2018 14:30

added close button stuff

f1cf3d3

merged conflictions

389cf17

console status icon tweaks

38206ba

pciavald approved these changes Jan 5, 2018

View reviewed changes

pciavald merged commit 0ad510c into particl:dev Jan 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Debug window console #470

Debug window console #470

vikas-cis-zz commented Dec 6, 2017 •

edited by AllienWorks

Loading

coveralls commented Dec 6, 2017

coveralls commented Dec 7, 2017

coveralls commented Dec 7, 2017

kewde Dec 12, 2017 •

edited

Loading

kewde Dec 12, 2017

kewde Dec 12, 2017

vikas-cis-zz Dec 12, 2017

kewde left a comment

coveralls commented Dec 12, 2017

coveralls commented Dec 16, 2017

anandsinghparihar commented Dec 19, 2017 •

edited

Loading

vikas-cis-zz commented Dec 19, 2017

coveralls commented Jan 3, 2018

coveralls commented Jan 3, 2018

vikas-cis-zz commented Jan 4, 2018

coveralls commented Jan 4, 2018

coveralls commented Jan 4, 2018

AllienWorks commented Jan 4, 2018

AllienWorks commented Jan 4, 2018

pciavald Jan 4, 2018

coveralls commented Jan 4, 2018

coveralls commented Jan 5, 2018

coveralls commented Jan 5, 2018

Debug window console #470

Debug window console #470

Conversation

vikas-cis-zz commented Dec 6, 2017 • edited by AllienWorks Loading

coveralls commented Dec 6, 2017

coveralls commented Dec 7, 2017

coveralls commented Dec 7, 2017

kewde Dec 12, 2017 • edited Loading

Choose a reason for hiding this comment

kewde Dec 12, 2017

Choose a reason for hiding this comment

kewde Dec 12, 2017

Choose a reason for hiding this comment

vikas-cis-zz Dec 12, 2017

Choose a reason for hiding this comment

kewde left a comment

Choose a reason for hiding this comment

coveralls commented Dec 12, 2017

coveralls commented Dec 16, 2017

anandsinghparihar commented Dec 19, 2017 • edited Loading

vikas-cis-zz commented Dec 19, 2017

coveralls commented Jan 3, 2018

coveralls commented Jan 3, 2018

vikas-cis-zz commented Jan 4, 2018

coveralls commented Jan 4, 2018

coveralls commented Jan 4, 2018

AllienWorks commented Jan 4, 2018

AllienWorks commented Jan 4, 2018

pciavald Jan 4, 2018

Choose a reason for hiding this comment

coveralls commented Jan 4, 2018

coveralls commented Jan 5, 2018

coveralls commented Jan 5, 2018

vikas-cis-zz commented Dec 6, 2017 •

edited by AllienWorks

Loading

kewde Dec 12, 2017 •

edited

Loading

anandsinghparihar commented Dec 19, 2017 •

edited

Loading