-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug window console #470
Debug window console #470
Conversation
3132e5a
to
343c599
Compare
this.currentTime = this.dateFormatter(new Date()); | ||
} | ||
|
||
private dateFormatter(d: Date) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this to utils?
I found a similar one here:
https://github.com/particl/partgui/blob/f4ad94c68e3ec85b6093c72cb96eed06f0f04882/src/app/wallet/shared/transaction.model.ts#L91-L100
Let's have one shared dateformat for the whole gui
src/app/wallet/wallet.module.ts
Outdated
@@ -25,7 +26,8 @@ import { routing } from './wallet.routing'; | |||
OverviewComponent, | |||
SettingsComponent, | |||
StakinginfoComponent, | |||
ColdstakeComponent | |||
ColdstakeComponent, | |||
ConsoleModalComponent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make the console, it's own module from Core-UI. You should be able to just use it, without having to import it I believe.
@@ -0,0 +1,55 @@ | |||
<div class="containerX"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, We have decided to have the same inside setting for future perspective as in future this will moves back to setting page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplication of code
Hey @vikas-cis Could please do following things first:
|
@gerlofvanek Can you please provide icon as suggested by @anandsinghparihar |
09d6551
to
79fef25
Compare
@AllienWorks it looks great just wondering about clear text (cross icon) which I have added for clearing the text, we don't need that ? |
Layout & design tweaked. @vikas-cis I've removed the icon, it's not needed at all. Modal's close button still needs implementation – can somebody do that? (I've tried to copy it from QR modal, but it's not working..) |
changes made
<div class="console-modal"> | ||
<!-- FIXME: make the close button work --> | ||
<button class="small-close_button"> | ||
<mat-icon fontSet="partIcon" fontIcon="part-circle-remove"></mat-icon> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be implemented
#469