Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added filter options on addressBook #607

Merged
merged 4 commits into from
Jan 16, 2018

Conversation

EagleEye25
Copy link

*added the ability to filter address book by using filters
*updated reg expressions in addressHelper utility

*added the ability to filter address book by using filters
*updated reg expressions in addressHelper utility
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 46.285% when pulling 98ecc41 on EagleEye25:address_book-filter into 29003d6 on particl:dev.

@pciavald
Copy link
Contributor

@HenkSwardt this is @AllienWorks 's job if i'm correct, will review when styled

@AllienWorks
Copy link
Member

Styled.

However there is still one issue – when selecting some address type from the filter, the pagination doesn't get updated (number of results & pages stays the same, e.g. even if 80% addresses are missing).

I believe we had this issue somewhere already, maybe in Address lookup modal, so you might look there for inspiration.

@AllienWorks AllienWorks removed their assignment Jan 10, 2018
@HenkSwardt
Copy link
Contributor

@EagleEye25 , Please look at above point from @AllienWorks

Thanks

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 46.325% when pulling 0512c45 on EagleEye25:address_book-filter into 29003d6 on particl:dev.

@kewde
Copy link
Collaborator

kewde commented Jan 12, 2018

#560 example of the pagination updating

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 46.325% when pulling b73feb0 on EagleEye25:address_book-filter into 29003d6 on particl:dev.

@pciavald
Copy link
Contributor

@EagleEye25 @HenkSwardt is that ready for review ?

@EagleEye25
Copy link
Author

@pciavald yes it it ready for review i believe

@AllienWorks
Copy link
Member

Tested and works nicely. Needs code review.

@pciavald
Copy link
Contributor

@EagleEye25 that works, please use this.log.{e,d} instead of console.log :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 46.663% when pulling 82fca18 on EagleEye25:address_book-filter into 29003d6 on particl:dev.

@pciavald pciavald merged commit 68d7913 into particl:dev Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants