-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added filter options on addressBook #607
Conversation
*added the ability to filter address book by using filters *updated reg expressions in addressHelper utility
@HenkSwardt this is @AllienWorks 's job if i'm correct, will review when styled |
Styled. However there is still one issue – when selecting some address type from the filter, the pagination doesn't get updated (number of results & pages stays the same, e.g. even if 80% addresses are missing). I believe we had this issue somewhere already, maybe in Address lookup modal, so you might look there for inspiration. |
@EagleEye25 , Please look at above point from @AllienWorks Thanks |
#560 example of the pagination updating |
@EagleEye25 @HenkSwardt is that ready for review ? |
@pciavald yes it it ready for review i believe |
Tested and works nicely. Needs code review. |
@EagleEye25 that works, please use this.log.{e,d} instead of console.log :) |
*added the ability to filter address book by using filters
*updated reg expressions in addressHelper utility