Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category Dropdown Menu Styling Enhancement Proposal #1155

Closed
cryptoguard opened this issue Sep 20, 2018 · 10 comments
Closed

Category Dropdown Menu Styling Enhancement Proposal #1155

cryptoguard opened this issue Sep 20, 2018 · 10 comments
Labels
type: Feature Request make a case for a change to a particular feature or a new feature to be added

Comments

@cryptoguard
Copy link

Right now, when selecting a category this is what the dropdown menu looks like:
screen shot 2018-09-19 at 9 56 27 pm

I was thinking perhaps it could be easier to navigate through the menu if all categories were collapsed, and only expanded once you click on it. Not sure if it is possible within a dropdown menu though...

So for example, in the screenshot above, instead of having (in order) the following when opening the dropdown menu:

  • Particl
    • Free Swag
  • High Values
    • Business / Corporate
      etc

You would have:

  • Particl
  • High Values
    etc

and only once you click on High Values would "Business / Corporate", as well as the other sub-categories for High Values, would show up. This would make it easier to choose the right category and make navigating through the options less of a hassle.

@kasprrr
Copy link

kasprrr commented Sep 22, 2018

To add to this, whenever a user presses the letter K, U or whatever on its keyboard, categories/countries starting with that specific letter should come up automatically (fairly standard drop-down behavior). Right now this is not the case

@HenkSwardt
Copy link
Contributor

Hi @kasprrr

Can you please provide me with your versions of the GUI as displayed at the bottom left corner of the Application as well as operating system details.

Reason I'm asking, we added this behavior to allow for hot searches a while back and it is working on my side. Please see below:

Countries:

image

Categories:

image

@zaSmilingIdiot
Copy link
Collaborator

@kasprrr Do you have any feedback for us on this?

@zaSmilingIdiot
Copy link
Collaborator

@cryptoguard Thanks for the suggestion. We are currently looking into completing the suggested menu behaviour.

@HenkSwardt
Copy link
Contributor

For now we have added a tooltip on hover to display any characters that might not fit into the display space,
Please see:
https://particl.atlassian.net/browse/PD-363
#1176

We also added a task to further add the ability to expand and collapse the main categories, giving you a more detailed view of all main categories.
Please see:
https://particl.atlassian.net/browse/PD-436

@kasprrr
Copy link

kasprrr commented Oct 10, 2018

Sorry for not getting back to you guys earlier.
So what i meant is that, for example, typing in "ne" brings up the following:
ne

Why is "Brunei" the first filtered country instead of "Nepal" / "Netherlands"? This is confusing to me.

0.0.42 market

@kasprrr
Copy link

kasprrr commented Oct 10, 2018

So for a dropdown such as "Country" first letter filter seems the way to go, for other dropdowns such as "Category" you may want to keep current filter system

@zaSmilingIdiot
Copy link
Collaborator

@kasprrr the dropdown options are filtered by any sequence of the characters matching the input text. And then ordered alphabetically. So as per your example, all of the filtered countries contain the letters "ne" in them, and then are displayed in the order shown due to being sorted alphabetically. Which is why Brunei appears before Netherlands.

It does however, make sense to filter the countries by a case-insensitive match that starts from the first sequence of input characters. As you suggest. This will mean that inputting 'n' will filter the options to those starting with the letter 'n'. We can add a feature request for this... as suggested, this should only be applicable to the country selection. @HenkSwardt can you please assist in creating the necessary JIRA ticket?

@btmr
Copy link

btmr commented Oct 14, 2018

@cryptoguard Reducing the amount of white space between the lines would also help to make the menu easier to read and navigate.
Collapsing the categories is a good idea. I don't mind the extra clicks because they provide a feeling of having control. Besides, a tidy menu is less exhausting to look at.

@zaSmilingIdiot zaSmilingIdiot added the type: Feature Request make a case for a change to a particular feature or a new feature to be added label Nov 11, 2019
@zaSmilingIdiot
Copy link
Collaborator

The original reported issue has been resolved, as the Categories menu is now a collapsible dropdown list.
The additional request to filter country dropdowns by a case-insensitive match that starts from the first sequence of input characters only, has also been previously completed.

Closing this as implementation for both requested enhancements is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Feature Request make a case for a change to a particular feature or a new feature to be added
Projects
None yet
Development

No branches or pull requests

5 participants